New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/teststructure #391

Merged
merged 13 commits into from Feb 26, 2015

Conversation

Projects
None yet
4 participants
@MrHug
Contributor

MrHug commented Feb 26, 2015

I have restructured the tests to have a clear distinction between unit tests and integration tests (only to conclude that there are very few of the first 馃槈)

Notes:

  • Tests are now split over /src/tests/unit/java and /src/tests/integration/java.
  • TestSuites can be found in /src/tests/integration/java
  • Packages in integration are now called xxx.tests.integration.yyy so that unit tests and integration tests for the same class can share a name.
  • A new gradle command intTest has been created that runs only the integration tests. All other commands should remain operational.

This is a start for issue #384.

@MrHug

This comment has been minimized.

Show comment
Hide comment
@MrHug

MrHug Feb 26, 2015

Contributor

Hmm apparently the travis build failed due to some dependency failing to download?

Execution failed for task ':syncany-cli:instrument'.
Could not resolve all dependencies for configuration ':syncany-cli:cobertura'.
Could not determine artifacts for component 'xml-apis:xml-apis:2.0.2'
Could not HEAD 'https://repo1.maven.org/maven2/xml-apis/xml-apis/2.0.2/xml-apis-2.0.2.jar'. ?Received status code 503 from server: Connection timed out

Contributor

MrHug commented Feb 26, 2015

Hmm apparently the travis build failed due to some dependency failing to download?

Execution failed for task ':syncany-cli:instrument'.
Could not resolve all dependencies for configuration ':syncany-cli:cobertura'.
Could not determine artifacts for component 'xml-apis:xml-apis:2.0.2'
Could not HEAD 'https://repo1.maven.org/maven2/xml-apis/xml-apis/2.0.2/xml-apis-2.0.2.jar'. ?Received status code 503 from server: Connection timed out

@cr0

This comment has been minimized.

Show comment
Hide comment
@cr0

cr0 Feb 26, 2015

Member
Member

cr0 commented Feb 26, 2015

@pimotte

This comment has been minimized.

Show comment
Hide comment
@pimotte

pimotte Feb 26, 2015

Member

@cr0, I can do that too (and I just did), so I assume you can too.

Member

pimotte commented Feb 26, 2015

@cr0, I can do that too (and I just did), so I assume you can too.

@MrHug

This comment has been minimized.

Show comment
Hide comment
@MrHug

MrHug Feb 26, 2015

Contributor

Hmm ok, because I have been changing gradle settings, so if this fails properly I might have made an error somewhere ;) Locally running tests etc through gradle went fine, but I'm still curious to see how it will do here.

Contributor

MrHug commented Feb 26, 2015

Hmm ok, because I have been changing gradle settings, so if this fails properly I might have made an error somewhere ;) Locally running tests etc through gradle went fine, but I'm still curious to see how it will do here.

@pimotte

This comment has been minimized.

Show comment
Hide comment
@pimotte

pimotte Feb 26, 2015

Member

Unfortunately, something is wrong. Did you use ./gradlew testGlobal when testing locally? It seems travis only ran the ones for which the package name did not change. Which, as I recall, should be none of them (I think the ones that were ran should have "unit" somewhere in the package name)

Member

pimotte commented Feb 26, 2015

Unfortunately, something is wrong. Did you use ./gradlew testGlobal when testing locally? It seems travis only ran the ones for which the package name did not change. Which, as I recall, should be none of them (I think the ones that were ran should have "unit" somewhere in the package name)

@MrHug

This comment has been minimized.

Show comment
Hide comment
@MrHug

MrHug Feb 26, 2015

Contributor

Currently only the integration tests have integration added as an extra package, the others have no extra package name, but are in the unit folder (integration are in the integration folder too ofc 馃槈)

If preferred I can also add the .unit. package to the unit tests?

As discussed in IRC, locally this gives me the correct result.

Contributor

MrHug commented Feb 26, 2015

Currently only the integration tests have integration added as an extra package, the others have no extra package name, but are in the unit folder (integration are in the integration folder too ofc 馃槈)

If preferred I can also add the .unit. package to the unit tests?

As discussed in IRC, locally this gives me the correct result.

@MrHug

This comment has been minimized.

Show comment
Hide comment
@MrHug

MrHug Feb 26, 2015

Contributor

Alright, so this becomes a bit more mysterious... A clean clone also fails to run the integration tests, yet a recursive diff only gives differences in the build/git folders and not in anything gradle related..

EDIT: From the IRC

[21:43:15] MrHug Yeah, I found it :D
[21:43:22] aureianimus 馃憤
[21:43:37] MrHug Turns out I didn't compile the integration tests for the "test" task, only for all other test tasks :P
[21:43:45] MrHug Fix coming your way :)
[21:43:52] MrHug I'll also include the .unit. thing

Contributor

MrHug commented Feb 26, 2015

Alright, so this becomes a bit more mysterious... A clean clone also fails to run the integration tests, yet a recursive diff only gives differences in the build/git folders and not in anything gradle related..

EDIT: From the IRC

[21:43:15] MrHug Yeah, I found it :D
[21:43:22] aureianimus 馃憤
[21:43:37] MrHug Turns out I didn't compile the integration tests for the "test" task, only for all other test tasks :P
[21:43:45] MrHug Fix coming your way :)
[21:43:52] MrHug I'll also include the .unit. thing

@pimotte

This comment has been minimized.

Show comment
Hide comment
@pimotte

pimotte Feb 26, 2015

Member

The folderpath for the ScenarioTests is the wrong way around (integration/tests instead of tests/integration). The rest looks good to me.

Member

pimotte commented Feb 26, 2015

The folderpath for the ScenarioTests is the wrong way around (integration/tests instead of tests/integration). The rest looks good to me.

@MrHug

This comment has been minimized.

Show comment
Hide comment
@MrHug

MrHug Feb 26, 2015

Contributor

Fixed :)

Contributor

MrHug commented Feb 26, 2015

Fixed :)

pimotte added a commit that referenced this pull request Feb 26, 2015

@pimotte pimotte merged commit 6cc14ed into syncany:develop Feb 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pimotte

This comment has been minimized.

Show comment
Hide comment
@pimotte

pimotte Feb 26, 2015

Member

Great start! 馃憤

Member

pimotte commented Feb 26, 2015

Great start! 馃憤

@binwiederhier

This comment has been minimized.

Show comment
Hide comment
@binwiederhier

binwiederhier Feb 28, 2015

Member

馃憤

Member

binwiederhier commented Feb 28, 2015

馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment