Skip to content

Conversation

@Naveen-Palanivel
Copy link
Contributor

No description provided.

@Naveen-Palanivel Naveen-Palanivel added the documentation Improvements or additions to documentation label Mar 7, 2024
@Naveen-Palanivel Naveen-Palanivel self-assigned this Mar 7, 2024
@SyncfusionBuild
Copy link
Contributor

Build Status: INPROGRESS 🔃
Build Location: MYSQL-Data-Binding-Documentation(871699)

@SyncfusionBuild
Copy link
Contributor

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: MYSQL-Data-Binding-Documentation(871699)
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0

@SyncfusionBuild
Copy link
Contributor

Build Status: INQUEUE 🕒
Build Location: MYSQL-Data-Binding-Documentation(871699)

@SyncfusionBuild
Copy link
Contributor

Build Status: INPROGRESS 🔃
Build Location: MYSQL-Data-Binding-Documentation(871699)

@SyncfusionBuild
Copy link
Contributor

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: MYSQL-Data-Binding-Documentation(871699)
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0

@SyncfusionBuild
Copy link
Contributor

Build Status: INPROGRESS 🔃
Build Location: MYSQL-Data-Binding-Documentation(871699)

@SyncfusionBuild
Copy link
Contributor

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: MYSQL-Data-Binding-Documentation(871699)
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0

@SyncfusionBuild
Copy link
Contributor

Build Status: INQUEUE 🕒
Build Location: MYSQL-Data-Binding-Documentation(871699)

@SyncfusionBuild
Copy link
Contributor

Build Status: INPROGRESS 🔃
Build Location: MYSQL-Data-Binding-Documentation(871699)

Copy link
Collaborator

@MaithiliyK MaithiliyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address my review comments

@SyncfusionBuild
Copy link
Contributor

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: MYSQL-Data-Binding-Documentation(871699)
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0

@Naveen-Palanivel
Copy link
Contributor Author

After discussions with Maithiliy mam, the following changes are proposed:

  1. Suggest using TotalRecords instead of the count variable.
  2. Suggest explaining aggregates.
  3. Suggest providing a link to Edit Mode.
  4. Suggest removing the data operation code in UrlAdaptor at the beginning.
  5. Suggest explaining more about grouping in CustomAdaptor.
  6. Change the same changes in MS SQL document also.

@SyncfusionBuild
Copy link
Contributor

Build Status: INPROGRESS 🔃
Build Location: MYSQL-Data-Binding-Documentation(871699)

@SyncfusionBuild
Copy link
Contributor

CI Status: SUCCESS ✅
Source Compilation: SUCCESS ✅
Build Location: MYSQL-Data-Binding-Documentation(871699)
Image Alt Text Error(s): 0
Image Size Error(s): 0
Image Name Error(s): 0
FT Layout Syntax Error(s): 0
Front matter Error(s): 0
File Path Error(s): 0
CodeSnippet File Path Missing Error(s): 0
Toc Anchor Tags Validation Error(s): 0

Copy link
Collaborator

@MaithiliyK MaithiliyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are fine

@MaithiliyK MaithiliyK merged commit 8dbd02b into hotfix/hotfix-v24.2.3 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants