Skip to content

Commit f5ad5cb

Browse files
Merge branch 'CI-Gitlab-MR-Templates' into 'development'
CI-Gitlab-MR-Templates See merge request essential-studio/Gitlab-MR-Templates!1
2 parents 783583e + 0c4b7e3 commit f5ad5cb

File tree

4 files changed

+143
-0
lines changed

4 files changed

+143
-0
lines changed

.gitlab/.gitkeep

Whitespace-only changes.

.gitlab/merge_request_templates/.gitkeep

Whitespace-only changes.
Lines changed: 73 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
1+
### Bug Description ###
2+
3+
Clearly and concisely describe the problem or feature (this cannot be empty).
4+
5+
### Root Cause ###
6+
7+
Briefly describe the root cause and analysis of the problem.
8+
If there is an internal discussion on the forum, provide the link.
9+
10+
### Reason for not identifying earlier ###
11+
12+
Find how it was missed in our earlier testing and development by analysing the below checklist. This will help prevent similar mistakes in the future.
13+
14+
**Guidelines/documents are not followed**
15+
16+
Common guidelines / Core team guideline
17+
Specification document
18+
Requirement document
19+
20+
**Guidelines/documents are not given**
21+
22+
Common guidelines / Core team guideline
23+
Specification document
24+
Requirement document
25+
26+
**Reason:**
27+
Mention any one or more reasons from the above points.
28+
29+
**Action taken:**
30+
What action did you take to avoid this in future?
31+
32+
**Related areas:**
33+
Is there any other related areas also to be addressed?
34+
35+
### Is Breaking issue? ###
36+
37+
If it is a breaking issue, provide the commit detail which caused this break.
38+
39+
### Solution description ###
40+
41+
Describe your code changes in detail for reviewers.
42+
43+
### Output screenshots ###
44+
45+
Post the output screenshots if an UI is affected or added due to this bug.
46+
47+
**Before changes:**
48+
Add the image which was taken before making these changes. Place a cursor here and click "Attach a file" button and upload the image.
49+
50+
**After changes:**
51+
Add the image which was taken after making these changes. Place a cursor here and click "Attach a file" button and upload the image.
52+
53+
### Areas affected and ensured ###
54+
55+
List out the areas are affected by your code changes.
56+
Is there any existing behavior change of other features due to this code change?
57+
58+
### Does it have any known issues?
59+
60+
If this fix contains any known issues, provide the proper details about the issues.
61+
62+
### Does it have memory leak?
63+
64+
Ensure the fix contains memory leak or not (if applicable).
65+
66+
### MR CheckList ###
67+
68+
- [ ] Does it follow the design [guidelines](https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/)? It is mandatory that, we should not move the changes without reading this.
69+
- [ ] Did UI automation passed without errors? If it is customer issue, make sure it is included in the IR automation.
70+
- [ ] Properly working in Xamarin.Forms [previewer](https://docs.microsoft.com/en-us/xamarin/xamarin-forms/xaml/xaml-previewer?tabs=vswin).
71+
- [ ] Ensured in iOS, Android, UWP and macOS (if supported).
72+
- [ ] Have you ensured the changes in Android API 19 and iOS 9?
73+
- [ ] Did you record this case in the unit test or UI test?
Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
### Feature description ###
2+
3+
Clearly and concisely describe the problem or feature (this cannot be empty).
4+
5+
### Analysis and design ###
6+
7+
If there is an external design, link to its project documentation area.
8+
If there is an internal discussion on the forum, provide the link.
9+
10+
### Solution description ###
11+
12+
Describe your code changes in detail for reviewers.
13+
14+
### Output screenshots ###
15+
16+
Post the output screenshots if an UI is affected or added due to this feature.
17+
18+
### Areas affected and ensured ###
19+
20+
List the areas are affected by your code changes.
21+
22+
### API Changes ###
23+
24+
List all API changes here (or just put None), example:
25+
26+
Added:
27+
- string ListView.GroupName { get; set; } //Bindable Property
28+
- int ListView.GroupId { get; set; } // Bindable Property
29+
- void ListView.Clear ();
30+
31+
Changed:
32+
- object ListView.SelectedItem => Cell ListView.SelectedItem
33+
34+
### Behavioral Changes ###
35+
36+
Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.
37+
38+
### Test cases ###
39+
40+
Provide the unit testing written file details to understand the use cases considered in this implementation.
41+
If there is no TDD (if it’s not possible to follow), provide the UI automation script location and the Excel file that contains the use cases considered in this implementation.
42+
Provide the test cases Excel file alone if the feature cannot be automated in any case.
43+
44+
List out all the scenarios you have tested after include these changes. You can refer the predefined scenarios from below link.
45+
46+
https://syncfusion.atlassian.net/wiki/display/CHARTXAMARIN/Chart+Test+Plan
47+
48+
### Testbed sample location ###
49+
50+
Provide the test bed sample location where code reviewers can review the new feature’s behaviors. This depends on the CI process that your team follows. It can be from NPMCI, HockeyApp, staging site, local server, etc.
51+
52+
### Does it have any known issues?
53+
54+
If this feature contains any known issues, provide the proper details about the issues.
55+
56+
### Does it have memory leak?
57+
58+
Ensure the feature contains memory leak or not (if applicable).
59+
60+
### MR CheckList ###
61+
62+
- [ ] Does it follow the design [guidelines](https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/)? It is mandatory that, we should not move the changes without reading this.
63+
- [ ] Did UI automation passed without errors? If it is customer issue, make sure it is included in the IR automation.
64+
- [ ] Properly working in Xamarin.Forms [previewer](https://docs.microsoft.com/en-us/xamarin/xamarin-forms/xaml/xaml-previewer?tabs=vswin).
65+
- [ ] Ensured in iOS, Android, UWP and macOS (if supported).
66+
- [ ] Have you added API comments if it is new API?
67+
- [ ] Does it need localization? If so, update resx file in [GitHub](https://github.com/syncfusion/xamarin-localized-texts).
68+
- [ ] Whether we have added new APIs? If so, whether it is as per the [guidelines](https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/)?
69+
- [ ] If changes are made in the Xamarin.Forms sample browser project file, whether it is included in the props file too? If not, your sample level changes will not reflect in the application published in the hockey app.
70+
- [ ] Have you ensured the changes in Android API 19 and iOS 9?

0 commit comments

Comments
 (0)