Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide the OpenPGP trust anchor as a binary file #6

Closed
anarcat opened this issue Mar 16, 2016 · 7 comments · Fixed by #23
Closed

provide the OpenPGP trust anchor as a binary file #6

anarcat opened this issue Mar 16, 2016 · 7 comments · Fixed by #23

Comments

@anarcat
Copy link

anarcat commented Mar 16, 2016

The Debian/Ubuntu install instructions indicate we should run:

curl -s https://syncthing.net/release-key.txt | sudo apt-key add -

While this is good, it's not considered best practice. Apart from verifying the key (which should be done separately, and is a whole different set of problems), the key should not be added to the global trust anchor in /etc/apt/trusted.gpg (which apt-key add - does). This makes it more difficult to track which package added which key, as this file can grow big and unmaintained.

A better way would be:

sudo wget -O /etc/apt/trusted.gpg.d/syncthing.gpg https://syncthing.net/release-key.gpg

It involves less commandline knowledge (no pipeline), is a single command, and will make the OpenPGP certificate end up in a separate file, distinct from all the others.

This is how Ubuntu PPAs manage their keys as well, and is considered a better practice than piping stuff through apt-key.

Note how the file name change: the .gpg file is not an ascii-armored file (as produced by gpg --export --armor) but a binary OpenPGP file. This is also expected (and will break APT if used with the txt file).

Ideally, there would be a PPA for Syncthing or it would just enter Debian already, but works still seems to be underway there (see bug #749887 in the Debian BTS).

Note: moved from syncthing/syncthing#2843

@calmh
Copy link
Member

calmh commented Mar 17, 2016

This seems reasonable, yes.

@calmh
Copy link
Member

calmh commented Mar 17, 2016

As a side note, I'd be happy to work with someone Debian savvy to get this into the repo proper, and to build a proper Debian source package. The current package builds are certainly not Debian-standard, but roughly get the job done as easily as possible. :) I know the Syncthing build process intimately, but got lost when trying to create a proper, working, Debian source package of this.

@anarcat
Copy link
Author

anarcat commented Mar 17, 2016

@calmh then you may want to get in touch with the people behind the ITP at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749887 :)

otherwise, the typical way of getting reviews is to upload the package to mentors.debian.net, and ask for a RFS (Request For Sponsorship) on the Debian bugtracker (reportbug wnpp if you are on Debian).

i'd be happy to help if the current owners of the ITP are not available.

@calmh
Copy link
Member

calmh commented Mar 17, 2016

Yeah, no, providing binary packages on apt.syncthing.net works for me. I have no intention of trying again to build the full package thing from source and interact with the Debian organization. But I'll happily handhold anyone who wishes to do so on all the technical aspects of building Syncthing properly.

@anarcat
Copy link
Author

anarcat commented Mar 17, 2016

Well, you don't have to get into the full bureaucracy - just send an email to Andreas Noteng <andreas@noteng.no> (which was working on the package last) with 749887@debian.org in CC, to mention where you're at and where you need help.

@calmh
Copy link
Member

calmh commented Mar 17, 2016

You misunderstand me. I'll try to be as clear as possible. I'm not working on creating a Debian package of Syncthing and probably never will be - my time is much better spent on things I understand and appreciate working with. As such I don't need any help with creating a Debian package. However if someone else is working on building a better package, and for any reason get stuck on the aspects of building Syncthing, I'll be happy to assist.

Now, lets let this issue be for the PGP key and move any further discussion to the forum. Perhaps there is someone else there that would be happy sink their teeth into building a package for Debian proper.

@anarcat
Copy link
Author

anarcat commented Mar 17, 2016

On 2016-03-17 10:53:28, Jakob Borg wrote:

You misunderstand me. I'll try to be as clear as possible. I'm not working on creating a Debian package of Syncthing and probably never will be - my time is much better spent on things I understand and appreciate working with. As such I don't need any help with creating a Debian package. However if someone else is working on building a better package, and for any reason get stuck on the aspects of building Syncthing, I'll be happy to assist.

I fully understand. :)

Now, lets let this issue be for the PGP key and move any further discussion to the forum. Perhaps there is someone else there that would be happy sink their teeth into building a package for Debian proper.

In my opinion, the proper forum is email, and the link I mentionned
earlier. :) That way the Debian package is available for all Debian
users without having to run weird commands as root ;)

a.

My passionate sense of social justice and social responsibility has
always contrasted oddly with my pronounced lack of need for direct
contact with other human beings and communities. I am truly a "lone
traveler" and have never belonged to my country, my home, my friends,
or even my immediate family, with my whole heart; in the face of all
these ties, I have never lost a sense of distance and a need for
solitude.
- Albert Einstein

@calmh calmh closed this as completed in #23 Jan 1, 2021
@syncthing syncthing locked and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants