From 780c8d84fb3157f406c8125de5adbf3f227e56e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20Wilczy=C5=84ski?= Date: Fri, 30 Oct 2020 13:59:55 +0900 Subject: [PATCH 1/3] users/config: Improve modTimeWindowS explanation (#582) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reword the explanation to make it more specific. Add an example of a file system (FAT), where the setting is applicable. Add a warning about the necessecity of setting the value before adding files to the folder. Explicitly mention the default values depending on the OS. Signed-off-by: Tomasz Wilczyński --- users/config.rst | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/users/config.rst b/users/config.rst index ef7eaa76..0629946f 100644 --- a/users/config.rst +++ b/users/config.rst @@ -354,9 +354,12 @@ copyOwnershipFromParent Requires running Syncthing as privileged user, or granting it additional capabilities (e.g. CAP_CHOWN on Linux). modTimeWindowS - Allowed modification timestamp difference when comparing files for equivalence. - To be used on systems that have unstable modification timestamps, that might change after being observed after - the last write operation. Used in Android only. + Allowed modification timestamp difference when comparing files for + equivalence. To be used on file systems which have unstable or + imprecise modification timestamps (e.g. FAT) that might change after + being recorded during the last write operation. Must be set before + adding files to the folder in order to take effect. Usually defaults + to 2 on Android, and always to 0 elsewhere. maxConcurrentWrites Maximum number of concurrent write operations while syncing. Defaults to 2. Increasing this might increase or From 127cb79a7f304333cd02217eac6a47cf3827e01b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20Wilczy=C5=84ski?= Date: Tue, 26 Jan 2021 16:32:09 +0900 Subject: [PATCH 2/3] wip MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Tomasz Wilczyński --- users/config.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/users/config.rst b/users/config.rst index 0629946f..52f1caa5 100644 --- a/users/config.rst +++ b/users/config.rst @@ -356,10 +356,10 @@ copyOwnershipFromParent modTimeWindowS Allowed modification timestamp difference when comparing files for equivalence. To be used on file systems which have unstable or - imprecise modification timestamps (e.g. FAT) that might change after - being recorded during the last write operation. Must be set before - adding files to the folder in order to take effect. Usually defaults - to 2 on Android, and always to 0 elsewhere. + imprecise modification timestamps that might change after being + recorded during the last write operation. Defaults to 2 on Android + when the folder is located on a FAT partition, and always to 0 + elsewhere. maxConcurrentWrites Maximum number of concurrent write operations while syncing. Defaults to 2. Increasing this might increase or From 9424c4e94c20446eb0264cdc92fc3b9d8bc917b9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20Wilczy=C5=84ski?= Date: Tue, 2 Feb 2021 13:24:35 +0900 Subject: [PATCH 3/3] wip MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Tomasz Wilczyński --- users/config.rst | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/users/config.rst b/users/config.rst index 52f1caa5..2498d4bb 100644 --- a/users/config.rst +++ b/users/config.rst @@ -355,11 +355,10 @@ copyOwnershipFromParent modTimeWindowS Allowed modification timestamp difference when comparing files for - equivalence. To be used on file systems which have unstable or - imprecise modification timestamps that might change after being - recorded during the last write operation. Defaults to 2 on Android - when the folder is located on a FAT partition, and always to 0 - elsewhere. + equivalence. To be used on file systems which have unstable + modification timestamps that might change after being recorded + during the last write operation. Defaults to 2 on Android when the + folder is located on a FAT partition, and always to 0 elsewhere. maxConcurrentWrites Maximum number of concurrent write operations while syncing. Defaults to 2. Increasing this might increase or