Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to start in Android Q Beta: TLS segment underaligned #1291

Open
callahad opened this issue Mar 13, 2019 · 8 comments

Comments

Projects
None yet
7 participants
@callahad
Copy link

commented Mar 13, 2019

Hi, Syncthing does not launch in Android Q. The in-app logs report:

--------- beginning of main
--------- beginning of crash
03-13 23:12:51.467 W/SyncthingNativeCode(21438): error: "/data/app/com.nutomic.syncthingandroid-kgE8B7kQjgjrpd1_hr0zbw==/lib/arm64/libsyncthing.so": executable's TLS segment is underaligned: alignment is 8, needs to be at least 64 for ARM64 Bionic
@callahad

This comment has been minimized.

Copy link
Author

commented Mar 14, 2019

Looks like this is due to an upstream bug in Go: golang/go#29674

@Catfriend1

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

Hmmm I'll wait a little bit until q is really in it's final stage before looking deeper... Thanks for the report.

@kvaster

This comment has been minimized.

Copy link

commented Mar 15, 2019

I've monkey-patch-fix for now for me:
Catfriend1#370

@jaseemabid

This comment has been minimized.

Copy link

commented Mar 20, 2019

Same issue on the Pixel 2 official Q build. Cannot use syncthing anymore :/

--------- beginning of main
03-17 17:51:14.737 W/SyncthingNativeCode( 8900): error: "/data/app/com.nutomic.syncthingandroid-nNfpUCdCsSnNG2p4dSoerA==/lib/arm64/libsyncthing.so": executable's TLS segment is underaligned: alignment is 8, needs to be at least 64 for ARM64 Bionic
--------- beginning of crash
03-17 17:52:00.946 W/SyncthingNativeCode( 8900): error: "/data/app/com.nutomic.syncthingandroid-nNfpUCdCsSnNG2p4dSoerA==/lib/arm64/libsyncthing.so": executable's TLS segment is underaligned: alignment is 8, needs to be at least 64 for ARM64 Bionic
@CedricCabessa

This comment has been minimized.

Copy link

commented Mar 23, 2019

I confirm this patch Catfriend1@3a188d4 fixes the issue on my Pixel 2 on Android Q

Catfriend1#370

@danblah

This comment has been minimized.

Copy link

commented Mar 28, 2019

I confirm this patch Catfriend1@3a188d4 fixes the issue on my Pixel 3 XL on Android Q

Catfriend1#370

@CedricCabessa

This comment has been minimized.

Copy link

commented Jun 16, 2019

any news on this?

The bug is still present in the last version of syncthing and Q beta 4 (this is the final api)

I'm very happy with Catfriend's patch :-)

@imsodin

This comment has been minimized.

Copy link
Member

commented Jun 16, 2019

Go 1.13 will have a proper fix. That's going to be released soon (beginning of August). And I personally wouldn't want to modify the Syncthing binary (or any binary) in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.