New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root only - Temporarily increase fs.inotify.max_user_watches to 128K (fixes #1208) #1209

Merged
merged 2 commits into from Aug 7, 2018

Conversation

Projects
None yet
3 participants
@Catfriend1
Copy link
Contributor

Catfriend1 commented Aug 6, 2018

Purpose
Fix the issue for root users by temporarily increasing "fs.inotify.max_user_watches" to 128K (instead of 8K).

Related issue:
#1208 "Syncthing is running out of inotify watches"
Forum discussion: https://forum.syncthing.net/t/android-failed-to-set-up-inotify-handler-please-increase-inotify-limits/11924/15

Testing
Verified working running syncthing rooted on Android 7.1.2 on device lg-h815 at commit ef5729d .

Tests
a) Running non-rooted
image

b) Running rooted
image

@Catfriend1 Catfriend1 self-assigned this Aug 6, 2018

@Catfriend1 Catfriend1 requested review from AudriusButkevicius and imsodin Aug 6, 2018

@imsodin
Copy link
Member

imsodin left a comment

Looks reasonable, can't say whether it's the right place/way to do this.

@Catfriend1

This comment has been minimized.

Copy link
Contributor Author

Catfriend1 commented Aug 7, 2018

At least it doesn't break anything for the "normal user". I even can't imagine this to be bad for root users as if the "sysctl" command may be unsupported in the future, it just will return an error exit code on the shell, not getting executed and the code being logged to logcat.

@AudriusButkevicius AudriusButkevicius merged commit 3bd1c75 into syncthing:master Aug 7, 2018

2 checks passed

Build (Syncthing Android) TeamCity build finished
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Catfriend1 Catfriend1 deleted the Catfriend1:rootIncInotify branch Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment