New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "receiveonly" folder type to UI and model (fixes #1210) #1211

Merged
merged 6 commits into from Aug 7, 2018

Conversation

Projects
None yet
2 participants
@Catfriend1
Copy link
Contributor

Catfriend1 commented Aug 7, 2018

Purpose:
The android wrapper's UI and config management needs support for the new "receiveOnly" folder type introduced in syncthing core v0.14.50rc.1 (and future versions).

Related issue:
#1210 "Add support for the 'receiveOnly' folder type migration"

Testing
Verified working correctly on device lg-h815 running Android 7.1.2 at commit 9f9eb11 . ( https://build.syncthing.net/repository/download/SyncthingAndroid_Build/24967:id/apk/debug/app-debug.apk )

@Catfriend1 Catfriend1 added the migration label Aug 7, 2018

@Catfriend1 Catfriend1 added this to the syncthing_v0.14.50 milestone Aug 7, 2018

@Catfriend1 Catfriend1 self-assigned this Aug 7, 2018

Catfriend1 added some commits Aug 7, 2018

Support suggesting the "sendonly" folder if a path chosen is readonly
Fix layout marginTop in folder_fragment

@Catfriend1 Catfriend1 changed the title WIP - Add "receiveonly" folder type to UI and model (fixes #1210) Add "receiveonly" folder type to UI and model (fixes #1210) Aug 7, 2018

@Catfriend1

This comment has been minimized.

Copy link
Contributor Author

Catfriend1 commented Aug 7, 2018

@Catfriend1 Catfriend1 requested review from calmh , AudriusButkevicius and imsodin Aug 7, 2018

@Catfriend1

This comment has been minimized.

Copy link
Contributor Author

Catfriend1 commented Aug 7, 2018

Found UI glitches: Description text is displayed "greyed out" which makes it hard to read > Fixed by removing the grey out; it's enough to grey out the action label. > commit 1c20595 and commit 9f9eb11

@Catfriend1

This comment has been minimized.

Copy link
Contributor Author

Catfriend1 commented Aug 7, 2018

Ok, ready for review. Tests were successful, see above.

@AudriusButkevicius
Copy link
Member

AudriusButkevicius left a comment

Should we do a beta after this?

mEditIgnores.setEnabled(false);
mFolder.type = Constants.FOLDER_TYPE_SEND_ONLY;

This comment has been minimized.

@AudriusButkevicius

AudriusButkevicius Aug 7, 2018

Member

I guess it will not be obvious why the setting cannot be changed?

This comment has been minimized.

@AudriusButkevicius

AudriusButkevicius Aug 7, 2018

Member

Should we add a toast or something when user clicks the setting that is disabled? I just don't want them left in the dark.

This comment has been minimized.

@Catfriend1

Catfriend1 Aug 7, 2018

Author Contributor

The explanation on the UI is shown. (string "your android version only allows you readonly access to the folder path given")

This comment has been minimized.

@Catfriend1

Catfriend1 Aug 7, 2018

Author Contributor

Hmm.. ok, an additional toast wouldn't hurt, commit aa6ded7

@Catfriend1

This comment has been minimized.

Copy link
Contributor Author

Catfriend1 commented Aug 7, 2018

( Should we do a beta after this? )
Beta would be nice if you've got the time. When it's in the master, I can also provide the beta apk if you like.

Add toast if the user clicks on "sendonly" label and
is not allowed to change it.

@AudriusButkevicius AudriusButkevicius merged commit 4b7024b into syncthing:master Aug 7, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Build (Syncthing Android) TeamCity build finished
Details
@AudriusButkevicius

This comment has been minimized.

Copy link
Member

AudriusButkevicius commented Aug 7, 2018

I'll do a beta later today.

@Catfriend1 Catfriend1 deleted the Catfriend1:addReceiveOnlyFolder branch Aug 7, 2018

@Catfriend1

This comment has been minimized.

Copy link
Contributor Author

Catfriend1 commented Aug 7, 2018

Thanks. Maybe we should compile syncthing core with the postfix "+[commit]" instead" of ".rc1" as @calmh previously pointed out an .rcX shouldn't get released as it enforces usage reporting?

@AudriusButkevicius

This comment has been minimized.

Copy link
Member

AudriusButkevicius commented Aug 7, 2018

I think its ok to have reporting on the beta track enabled by force. We're not going to release the rc to prod.

@Catfriend1

This comment has been minimized.

Copy link
Contributor Author

Catfriend1 commented Aug 7, 2018

For me, that's okay too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment