Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mode and modification times on directories should be preserved #11

Closed
jpjp opened this issue Jan 6, 2014 · 11 comments

Comments

Projects
None yet
3 participants
@jpjp
Copy link
Contributor

commented Jan 6, 2014

If I sync a file, the metadata on the target is different from on the source. So far I have only checked output from stat, not xattrs.

@calmh

This comment has been minimized.

Copy link
Member

commented Jan 6, 2014

Could you expand on which metadata it is you are looking for, specifically (i.e. Spotlight keywords, labels, resource forks, Windows extended attributes...)? Some might be possible, some might be to OS specific to be suitable, I'm not sure, haven't thought it through yet. :)

@jpjp

This comment has been minimized.

Copy link
Contributor Author

commented Jan 6, 2014

Sure: everything returned by stat, and most of the stuff returned by attr -l FILE (probably not the selinux context though)

@calmh

This comment has been minimized.

Copy link
Member

commented Jan 6, 2014

Right. That's Linux specific then; not impossible for sure, but not probably something I will prioritize.

@jpjp

This comment has been minimized.

Copy link
Contributor Author

commented Jan 6, 2014

Your choice :) I just found it confusing that the directories sorted by date were different. I think it might prevent users from seeing which version of a file they have if the mtime, etc is different.

@calmh

This comment has been minimized.

Copy link
Member

commented Jan 6, 2014

Ah... Times should be preserved for sure. It does that now for files, because files are what it synchronizes, but not directories. That also means empty directories will not be synchronized (or deleted)... Perhaps that is something that should be fixed. I'll tag that as a bug.

@calmh

This comment has been minimized.

Copy link
Member

commented Jan 7, 2014

I'm changing the title on this to apply to the directory time issue; feel free to open other issues on other metadata.

@jpjp

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2014

@calmh

This comment has been minimized.

Copy link
Member

commented Jan 9, 2014

This turned out to be more of a pain than I expected, shuffling it forward a bit while I think about more elegant solutions...

@jpjp

This comment has been minimized.

Copy link
Contributor Author

commented Jan 28, 2014

Writing this here so I don't forget (again): touch ~/Sync/file1 will not be synced across the cluster because it is zero length.

@calmh

This comment has been minimized.

Copy link
Member

commented Jan 28, 2014

(-> #44)

@calmh calmh modified the milestones: v1.0, v0.6 Feb 10, 2014

@calmh calmh modified the milestones: v0.8, v1.0 Mar 30, 2014

@calmh

This comment has been minimized.

Copy link
Member

commented Apr 2, 2014

This is ready to merge soon, notes and discussion at http://discourse.syncthing.net/t/v0-7-2-directory-syncing/16

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.