Update link in web interface does not work on OpenBSD.

[vext01]

If you click the update link on the web interface on OpenBSD, you will get an error:

upgrading: readlink /proc/curproc/file: no such file or directory

OpenBSD (and probably some other UNIXs) does not have /proc.

Presumably you are trying to get the server's PID? It is typical to write a PID file into /var/run.

Thanks

[kozec]

/proc/curproc/file will return filename of current process, not PID. Shouldn't that be same thing as os.Args[0] ?

[AudriusButkevicius]

It seems that:
https://github.com/syncthing/syncthing/blob/8f9b8a8550a4f1ff483065991427c2535440df5c/Godeps/_workspace/src/github.com/calmh/osext/osext_procfs.go

Targets OpenBSD specifically, so I am a bit puzzled why it's not there.

[AudriusButkevicius]

I agree though that os.Args[0] should be sufficient.
Though some programs do patch that up to show up under a different name in the process tree.

[kozec]

Targets OpenBSD specifically, so I am a bit puzzled why it's not there.

Unlike Linux, ObenBSD supports procfs only as optional feature and only on some architectures.

//edit: rephrased

[AudriusButkevicius]

I'll have to wait for @calmh to answer this.

[calmh]

Right. So this only works on the OpenBSDs that have a /proc. We need /proc to find the location of the binary so we can upgrade it. We should probably just do this check earlier and disable auto upgrades if we can't determine the binary location.

(os.Args[0] is what the user called the binary as, which may not contain the path)

[AudriusButkevicius]

Isn't filepath.Join(os.Getwd(), os.Args[0]) still the same thing?
I cannot see how you could invoke the binary differently.

[calmh]

If I just type syncthing in my home directory, os.Args[0] is syncthing, Getwd() is my home directory, the binary might be anywhere in my $PATH. There are other corner cases, but point is Args[0] isn't the truth.

[AudriusButkevicius]

Ah yes, I am just used to not having anything in my path.

[calmh]

Without /proc we can't determine our binary location and can't auto upgrade. Closing.

[mulander]

Maybe adding an optional binary location config path would help solving the issue? People who prefer auto updates could set their location this way making it independent off /proc.

[calmh]

Maybe one of the three OpenBSD users feel strongly enough about this to propose a patch. :D

[canton7]

If you look at the github download stats, there are at least 160 of them...

[calmh]

No problem then.

[mulander]

@calmh I'll provide a patch with the proposed config option solution. Stay tuned ;)

[calmh]

@mulander Maybe just fall back to argv[0] and if that's not an absolute path explain the problem to the user?

[mulander]

@calmh sounds reasonable to me. I just finished work for today so will spent some time trying out options - will avoid adding new config for it and will report back with a patch or more info.

[AudriusButkevicius]

Or check $PATH/srgv[0]

[mulander]

@calmh @AudriusButkevicius I was on my way to do a best effort implementation and finally found out how syncthing locates the current executable. It seems that you guys depend on a frozen version of kardianos/osext using Godeps.

Seems that this whole issue is already fixed upstream and all you need is to pull this commit provided by ajacoutot who is an OpenBSD developer.

[AudriusButkevicius]

Right, we only need to upgrade that then.

[plouj]

On a related note, could you also pull in the changes from kardianos/osext@431e263 ? I tried to do it myself, but I can't figure out godep :(

[calmh]

There you go. Shutting down this issue to avoid piling more things on it. ;)