Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show last connection error per discovered address #3345

Closed
calmh opened this issue Jun 26, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@calmh
Copy link
Member

commented Jun 26, 2016

After #3340, we should track and show the error we got when trying to connect to each configured or discovered address. This could be "time out", "connection refused" etc and will be somewhat raw and technical but still help people figure out what's going on.

@calmh calmh added the enhancement label Jun 26, 2016

@MichaelGooden

This comment has been minimized.

Copy link

commented Jun 26, 2016

It could also be beneficial to display a "last connection attempt" timestamp as well as a "next connection attempt" timestamp?

(Per discovered address)

@calmh calmh added this to the Unplanned (Contributions Welcome) milestone Aug 14, 2016

@calmh calmh removed this from the Unplanned (Contributions Welcome) milestone Feb 11, 2018

calmh added a commit to calmh/syncthing that referenced this issue May 16, 2019

lib/api, lib/connections, gui: Show connection error for disconnected…
… devices (fixes syncthing#3345)

This adds functionality in the connetions service to track the last
error per address. That is in turn exposed in the /rest/system/status
API method, as that is also where we already show the listener status
from the connection service.

The GUI uses this info where it lists addresses, showing errors (if any)
in red underneath each address.

I also slightly refactored the existing status method on the connection
service to have a better name and return typed information.

calmh added a commit to calmh/syncthing that referenced this issue May 16, 2019

lib/api, lib/connections, gui: Show connection error for disconnected…
… devices (fixes syncthing#3345)

This adds functionality in the connetions service to track the last
error per address. That is in turn exposed in the /rest/system/status
API method, as that is also where we already show the listener status
from the connection service.

The GUI uses this info where it lists addresses, showing errors (if any)
in red underneath each address.

I also slightly refactored the existing status method on the connection
service to have a better name and return typed information.

calmh added a commit to calmh/syncthing that referenced this issue May 16, 2019

lib/api, lib/connections, gui: Show connection error for disconnected…
… devices (fixes syncthing#3345)

This adds functionality in the connetions service to track the last
error per address. That is in turn exposed in the /rest/system/status
API method, as that is also where we already show the listener status
from the connection service.

The GUI uses this info where it lists addresses, showing errors (if any)
in red underneath each address.

I also slightly refactored the existing status method on the connection
service to have a better name and return typed information.

@calmh calmh added this to the v1.2.0 milestone May 17, 2019

calmh added a commit to calmh/syncthing that referenced this issue May 23, 2019

Merge branch 'master' into crashrep
* master: (25 commits)
  gui, man, authors: Update docs, translations, and contributors
  lib/model: Consistently cleanup model in tests (syncthing#5724)
  golang-ci: Turn up the heat
  cmd/ursrv: Lint fixes
  build(deps): bump github.com/prometheus/client_golang (syncthing#5729)
  lib/model, lib/testutils: Test closing a connection on folder restart (syncthing#5707)
  lib/model: Fix test flakyness regression (ref syncthing#5592) (syncthing#5718)
  test: Report time per MiB on transfer benchs (syncthing#5711)
  docker: Create entrypoint script (fixes syncthing#5631) (syncthing#5635)
  lib/model: Refactor file deletions when pulling (syncthing#5699)
  cmd/ursrv: Add F-droid and some third party distributors to the distrubtion summary
  lib/api, lib/connections, gui: Show connection error for disconnected devices (fixes syncthing#3345) (syncthing#5727)
  authors: Update acolomb (fixes syncthing#5726)
  cmd/ursrv: Summarize known distribution channels
  gui, man, authors: Update docs, translations, and contributors
  lib/model: Remove superfluous check for IndexID in remote ClusterConfig (syncthing#5717)
  build(deps): bump github.com/lib/pq from 1.0.0 to 1.1.1 (syncthing#5714)
  build(deps): bump github.com/oschwald/geoip2-golang from 1.1.0 to 1.3.0 (syncthing#5713)
  build(deps): bump github.com/mattn/go-isatty from 0.0.4 to 0.0.7 (syncthing#5712)
  build(deps): bump github.com/gogo/protobuf from 1.2.0 to 1.2.1 (syncthing#5715)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.