Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative, more resource efficient puller #4107

Closed
calmh opened this issue Apr 17, 2017 · 2 comments
Closed

Alternative, more resource efficient puller #4107

calmh opened this issue Apr 17, 2017 · 2 comments
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug)

Comments

@calmh
Copy link
Member

calmh commented Apr 17, 2017

When implementing the new puller, we could keep in mind that it might be useful with a completely different, less resource intensive but also less efficient algorithm.

The current puller, and the future graph based one, will require keeping essentially the entire file set in memory. We need this for ordering (sorting), dependencies, rename detection, and so on.

But we could also use an altogether simpler approach where we don't do rename detection or dependencies or anything fancy and just directly work out of the database, item by item. It'll suck in some respects (delete and re-download instead of rename, fail and have to retry for some changes, etc). But it could also work in a very small amount of RAM.

As an option. [X] Use a sucky puller but spare my RAM

@AudriusButkevicius
Copy link
Member

AudriusButkevicius commented Apr 17, 2017

or the graph could be on disk.
the sucky puller is pretty much the existing puller, minus some stuff that goes into ram (such as the job queue)

@calmh
Copy link
Member Author

calmh commented Apr 17, 2017 via email

@calmh calmh added the enhancement New features or improvements of some kind, as opposed to a problem (bug) label May 4, 2017
@calmh calmh added this to the Unplanned (Contributions Welcome) milestone May 4, 2017
@calmh calmh removed this from the Unplanned (Contributions Welcome) milestone Feb 11, 2018
@calmh calmh closed this as not planned Won't fix, can't repro, duplicate, stale Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug)
Projects
None yet
Development

No branches or pull requests

2 participants