-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folder escape via versioning symlinks #4286
Labels
bug
A problem with current functionality, as opposed to missing functionality (enhancement)
frozen-due-to-age
Issues closed and untouched for a long time, together with being locked for discussion
Comments
calmh
added a commit
that referenced
this issue
Aug 8, 2017
…#4286) Prior to this, the following is possible: - Create a symlink "foo -> /somewhere", it gets synced - Delete "foo", it gets versioned - Create "foo/bar", it gets synced - Delete "foo/bar", it gets versioned in "/somewhere/bar" With this change, versioners should never version symlinks.
calmh
added a commit
that referenced
this issue
Aug 8, 2017
…#4286) Prior to this, the following is possible: - Create a symlink "foo -> /somewhere", it gets synced - Delete "foo", it gets versioned - Create "foo/bar", it gets synced - Delete "foo/bar", it gets versioned in "/somewhere/bar" With this change, versioners should never version symlinks.
calmh
added a commit
that referenced
this issue
Aug 8, 2017
* master: lib/versioner: Clean the versions dir of symlinks, not the full folder lib/model: Disable symlink attack test on Windows lib/model, lib/versioner: Prevent symlink attack via versioning (fixes #4286) gui: Add title attributes for shared devices/folders
viable-hartman
pushed a commit
to viable-hartman/syncthing
that referenced
this issue
Aug 25, 2017
…syncthing#4286) Prior to this, the following is possible: - Create a symlink "foo -> /somewhere", it gets synced - Delete "foo", it gets versioned - Create "foo/bar", it gets synced - Delete "foo/bar", it gets versioned in "/somewhere/bar" With this change, versioners should never version symlinks.
CVE-2017-1000420 was assigned to this issue. |
Yep, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
A problem with current functionality, as opposed to missing functionality (enhancement)
frozen-due-to-age
Issues closed and untouched for a long time, together with being locked for discussion
Syncthing erronously versions symlinks when they are deleted. If a directory is then created with the same name, a file created in that directory, and the file deleted, it is moved into the symlink target.
The text was updated successfully, but these errors were encountered: