Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid lots and lots of announced addresses in the presence of symmetric NAT #4519

Closed
calmh opened this issue Nov 17, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@calmh
Copy link
Member

commented Nov 17, 2017

When behind symmetric NAT we will get a new port mapping for every STUN lookup, which is (worst case) every 24 seconds. Worst case this means we accumulate up to 150 useless KCP addresses (one hour's worth) on the discovery server.

We should probably just not announce any KCP addresses to the global discovery system when we are behind an unfriendly NAT type.

Relates to #4459

@calmh calmh added the enhancement label Nov 17, 2017

@calmh calmh added this to the Planned milestone Nov 17, 2017

AudriusButkevicius added a commit to AudriusButkevicius/syncthing that referenced this issue Nov 17, 2017

@st-review st-review closed this in 0518a92 Nov 17, 2017

@calmh calmh modified the milestones: Planned, v0.14.41 Dec 3, 2017

@syncthing syncthing locked and limited conversation to collaborators Nov 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.