Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI folder/device status rows should handle longer values nicer #4531

Closed
sisu4syncthing opened this issue Nov 20, 2017 · 9 comments

Comments

Projects
None yet
8 participants
@sisu4syncthing
Copy link

commented Nov 20, 2017

Hi,
in the WebGui, can we have the full view on IPV6 adresses?

They are unreadable because of the "..." at the end of each adress.

Steps to reproduce:

Open the WebGUI and open Remote Devices to see some IPs

  • what you expected to happen instead

The whole IP Adress, so I can compare or textcopy them.

Versions:
Syncthing Version: v0.14.40, 64Bit on Mac/Linux/Windows
OS Version: Windows 7 / Mac OSX Sierra
Browser Version: FireFox / Safari

Screenshots:
bildschirmfoto 2017-11-19 um 21 19 43

bildschirmfoto 2017-11-19 um 21 30 30

@calmh

This comment has been minimized.

Copy link
Member

commented Nov 20, 2017

The more general problem is that the table layout requires giving the columns fixed space, which is currently 50/50.

@alyandon

This comment has been minimized.

Copy link

commented Nov 23, 2017

I have on occasion needed to fish out IPv6 addresses from Syncthing's web UI and it'd be nice to not have to use the DOM inspector to do it. I can't say that I've had to do it often enough that it is really a big deal to me though. Maybe a click handler to copy addresses to the clipboard feature would be better?

@calmh

This comment has been minimized.

Copy link
Member

commented Nov 23, 2017

@calmh calmh changed the title IPV6 Adresses are cutted with "..." in the WebGui, should be human readable. GUI folder/device status rows should handle longer values nicer Nov 26, 2017

@calmh calmh added the enhancement label Nov 26, 2017

@calmh calmh added this to the Unplanned (Contributions Welcome) milestone Nov 26, 2017

@bugith

This comment has been minimized.

Copy link

commented Nov 30, 2017

I also met this kind of difficulty. I worked around temporally with zoom out (Ctrl+- and Ctrl++|Ctrl+0 in FF)

@generalmanager

This comment has been minimized.

Copy link

commented Jan 2, 2018

+1 for the clipboard feature

@AudriusButkevicius

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

Please stop bikeshedding and +1'ing random feature requests that do not relate to the original issue.

@generalmanager

This comment has been minimized.

Copy link

commented Jan 2, 2018

Sure, I'll refrain from +1'ing and use the reaction emojis instead, I also didn't notice that there hasn't been any activity for over a month and I apoligize for that.
I really didn't intend to bikeshed or nitpick, and I don't get how the idea to offer a "copy to clipboard" functionality could seem unrelated to the original issue. The title is literally about nicer handling, with part of the authors intention beeing to be ably to copy the IPv6. As the most simplistic approach (show it in full) appears infeasible/unneccessarily complicated, this seemed like the best alternative.

@calmh calmh removed this from the Unplanned (Contributions Welcome) milestone Feb 11, 2018

@otbutz

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

Just fiddled a bit with the CSS using Firefox page inspector. It seems that setting table-layout: auto; for table.table-condensed fixes the display of long IPv6 addresses without noticeable visual regressions. I'm going to test it a bit further later.

Before:
grafik

After:
grafik

table.table-condensed {
table-layout: fixed;
}

@imsodin

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

Check a few modals at various window sizes - I have fiddled with those table layouts as well in the past and I seem to remember that auto has some very undesirable effects. If my memory is correct, but auto is nice for this particular element you might consider adding a subclass or just locally changing the properties (no idea what the "proper way" is, I have hardly any CSS/HTML knowledge).

@calmh calmh closed this in #5565 Apr 18, 2019

calmh added a commit that referenced this issue Apr 18, 2019

@calmh calmh added this to the v1.1.3 milestone Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.