Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic in "pfilter" package on 32 bit architectures #4537

Closed
xjtdy888 opened this issue Nov 22, 2017 · 1 comment

Comments

Projects
None yet
4 participants
@xjtdy888
Copy link
Contributor

commented Nov 22, 2017

Panic at 2017-11-21T16:45:01+08:00
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x0 pc=0x4012cc]

goroutine 571 [running]:
sync/atomic.AddUint64(0x2059a13c, 0x1, 0x0, 0x5dc, 0xb8)
/usr/local/go/src/sync/atomic/asm_386.s:112 +0xc
github.com/syncthing/syncthing/vendor/github.com/AudriusButkevicius/pfilter.(*PacketFilter).loop(0x2059a120)
/usr/local/gopkg/src/github.com/syncthing/syncthing/vendor/github.com/AudriusButkevicius/pfilter/filter.go:132 +0x105
created by github.com/syncthing/syncthing/vendor/github.com/AudriusButkevicius/pfilter.(*PacketFilter).Start
/usr/local/gopkg/src/github.com/syncthing/syncthing/vendor/github.com/AudriusButkevicius/pfilter/filter.go:90 +0x33

@AudriusButkevicius AudriusButkevicius added this to the Planned milestone Nov 22, 2017

@calmh

This comment has been minimized.

Copy link
Member

commented Nov 22, 2017

This is an alignment problem on 32 bit archs. Counters need to be at the top of the struct.

@calmh calmh changed the title panic: pfilter Panic in "pfilter" package on 32 bit architectures Nov 22, 2017

AudriusButkevicius added a commit to AudriusButkevicius/syncthing that referenced this issue Nov 22, 2017

@st-review st-review closed this in 67c39b2 Nov 22, 2017

calmh added a commit that referenced this issue Nov 23, 2017

vendor: Update pfilter (fixes #4537)
GitHub-Pull-Request: #4539

calmh added a commit that referenced this issue Nov 23, 2017

Merge branch 'release'
* release:
  vendor: Update pfilter (fixes #4537)
  lib/connections: Actually fix LAN detection, for real (ref #4534)

@calmh calmh modified the milestones: Planned, v0.14.41, v0.14.42 Dec 3, 2017

@syncthing syncthing locked and limited conversation to collaborators Nov 23, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.