Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress emitter doesn't start from config change if disabled at startup #4613

Closed
calmh opened this issue Dec 26, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@calmh
Copy link
Member

commented Dec 26, 2017

Just a todo for something I ran into while looking at something else. The Serve() method is only run if the interval is positive when the model starts, yet it may become positive later due to a config commit and the progress emitter looks like it's made to handle this. Fix is trivial, but I want to write a test at the same time.

@calmh calmh added the bug label Dec 26, 2017

imsodin added a commit to imsodin/syncthing that referenced this issue Mar 27, 2019

@imsodin imsodin closed this in 3bea59b Apr 13, 2019

@calmh calmh added this to the v1.1.3 milestone Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.