Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging debugging flags stay after disabling all debug facilities in the web UI #4780

Closed
imsodin opened this Issue Feb 26, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@imsodin
Copy link
Member

imsodin commented Feb 26, 2018

This is something in between a bug and a feature request: When no debug env vars are set, but some facilities are enabled and then disabled in the web UI, the debug logging flags (filename, precise timestamps) persist. Only way to reset it is to restart syncthing. This is a bit annoying e.g. on my homeserver when temporarily testing something and then reverting to "business as usual", as logcheck filters don't work anymore with the different format.

@AudriusButkevicius

This comment has been minimized.

Copy link
Member

AudriusButkevicius commented Feb 26, 2018

I think we should show these always, as I had cases where I just asked people to enable debugging something just to get the line numbers. K8s does this for example.

@calmh

This comment has been minimized.

Copy link
Member

calmh commented Feb 26, 2018

We have flags to do that. (-logflags 20) For the vast majority of users the line number stuff is just meaningless noise.

I agree with imsodin though - if we set flags when we enable debug facilities we should clear them again when all are unset.

@calmh calmh added the bug label Apr 19, 2018

imsodin added a commit to imsodin/syncthing that referenced this issue Oct 18, 2018

@imsodin imsodin closed this in 406bedf Oct 23, 2018

@calmh calmh added this to the v0.14.53 milestone Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.