Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version restore not possible with custom versioning path set #5338

Closed
pedrojvaz opened this issue Nov 25, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@pedrojvaz
Copy link

commented Nov 25, 2018

Syncthing cannot find previous versions when using Staggered File Versioning using the option to define a folder path for the versioning.
While syncthing correctly saves versions in the defined folder, when clicking "Versions", it display "No Data.", making it impossible to restore previous versions.

Version Information

Syncthing Version: v0.14.52, Linux (ARM)
OS Version: Raspbian GNU/Linux, 9 (stretch)
Browser Version: Firefox Dev Ed, 64.0b12 (64-bit)

@canton7

This comment has been minimized.

Copy link
Member

commented Nov 25, 2018

See discussion on the forum.

@calmh calmh changed the title File version contains "No Data." Version restore not possible with custom versioning path set Nov 26, 2018

AudriusButkevicius added a commit to AudriusButkevicius/syncthing that referenced this issue Feb 6, 2019

lib/versioner: Restore for all versioners, cross-device support
Fixes syncthing#4631
Fixes syncthing#4586
Fixes syncthing#1634
Fixes syncthing#5338
Fixes syncthing#5419

This also:
1. Forces all versioners to use the same tagging, meaning that trash can versioner will start adding timestamps (cleanup is mtime based so it's ok)
2. Removes Rename function which seems not to be used anywhere important anymore, and TryRename is now RenameOrCopy
3. Versioning (and ton of other stuff) should now happen across filesystems when possible.
4. Adds versioning support for untagged and old file.txt~2014... tagged files. (There was no other way, in order to support trashcan versioner)

AudriusButkevicius added a commit that referenced this issue Apr 28, 2019

lib/versioner: Restore for all versioners, cross-device support (#5514)
* lib/versioner: Restore for all versioners, cross-device support

Fixes #4631
Fixes #4586
Fixes #1634
Fixes #5338
Fixes #5419

@calmh calmh added this to the v1.1.3 milestone Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.