/syncthing

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor bug: TERM signaling not passed to syncthing process #5493

Closed
LE0N7 opened this Issue Jan 31, 2019 · 0 comments

Comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
  v1.1.0
2 participants
@LE0N7 @calmh
@LE0N7
Copy link

LE0N7 commented Jan 31, 2019

Details

... as further detailed in https://forum.syncthing.net/t/cli-shutdown/12798

"When intercepting TERM it kills the main syncthing process, instead of signalling it to stop" [2]

Version Information

Tested with
Syncthing Version: Syncthing v1.0.0 "Erbium Earthworm" (Macports build)
OS Version: ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

@LE0N7 LE0N7 changed the title Monitor bug: TERM signaling not passed syncthing process Monitor bug: TERM signaling not passed to syncthing process Jan 31, 2019

imsodin added a commit to imsodin/syncthing that referenced this issue Jan 31, 2019

@imsodin
cmd/syncthing: Pass SIGTERM on in monitor (fixes syncthing#5493)
Verified
This commit was signed with a verified signature.
@imsodin imsodin Simon Frei
GPG key ID: 7C31D23ECB1006F3 Learn about signing commits
99d5805

@calmh calmh closed this in 5605877 Jan 31, 2019

@calmh calmh added the bug label Jan 31, 2019

calmh added a commit to calmh/syncthing that referenced this issue Feb 2, 2019

@calmh
Merge branch 'master' into largeb 
* master: (61 commits)
  build: Remove outdated&non-functional setup command (fixes syncthing#5454) (syncthing#5455)
  cmd/syncthing, lib/config: Update default config creation (syncthing#5492)
  golangci: Add config file
  cmd/syncthing: Correct strings.HasPrefix args order (syncthing#5498)
  all: Revert the underscore sillyness
  all: A few more interesting linter fixes (syncthing#5502)
  all: Even more boring linter fixes (syncthing#5501)
  all: Bunch of more linter fixes (syncthing#5500)
  all: Fix some linter errors (syncthing#5499)
  lib/db: Fix race in NamespacedKV (syncthing#5496)
  docker: Build outside GOPATH (fixes syncthing#5495)
  cmd/syncthing: Pass SIGTERM on in monitor (fixes syncthing#5493) (syncthing#5494)
  lib/model: In tests disable watching for changes by default (fixes syncthing#5246) (syncthing#5485)
  gui, man, authors: Update docs, translations, and contributors
  test, lib/rc: Integration test fixes and polish (syncthing#5488)
  mod: Update dependencies and tidy (fixes syncthing#5311) (syncthing#5486)
  lib/config: Add omitempty to DeprecatedMinHomeDiskFreePct (fixes syncthing#5482) (syncthing#5484)
  all: Copy owner/group from parent (fixes syncthing#5445) (syncthing#5479)
  vendor: rm -rf vendor (syncthing#5478)
  lib/model: Improve errors while pulling (syncthing#5474)
  ...
7f08b88

calmh added a commit to calmh/syncthing that referenced this issue Feb 2, 2019

@calmh
Merge branch 'master' into ldap3 
* master: (62 commits)
  cmd/syncthing: Fixup previous commit
  build: Remove outdated&non-functional setup command (fixes syncthing#5454) (syncthing#5455)
  cmd/syncthing, lib/config: Update default config creation (syncthing#5492)
  golangci: Add config file
  cmd/syncthing: Correct strings.HasPrefix args order (syncthing#5498)
  all: Revert the underscore sillyness
  all: A few more interesting linter fixes (syncthing#5502)
  all: Even more boring linter fixes (syncthing#5501)
  all: Bunch of more linter fixes (syncthing#5500)
  all: Fix some linter errors (syncthing#5499)
  lib/db: Fix race in NamespacedKV (syncthing#5496)
  docker: Build outside GOPATH (fixes syncthing#5495)
  cmd/syncthing: Pass SIGTERM on in monitor (fixes syncthing#5493) (syncthing#5494)
  lib/model: In tests disable watching for changes by default (fixes syncthing#5246) (syncthing#5485)
  gui, man, authors: Update docs, translations, and contributors
  test, lib/rc: Integration test fixes and polish (syncthing#5488)
  mod: Update dependencies and tidy (fixes syncthing#5311) (syncthing#5486)
  lib/config: Add omitempty to DeprecatedMinHomeDiskFreePct (fixes syncthing#5482) (syncthing#5484)
  all: Copy owner/group from parent (fixes syncthing#5445) (syncthing#5479)
  vendor: rm -rf vendor (syncthing#5478)
  ...
387f20b

@calmh calmh added this to the v1.1.0 milestone Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment