Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking block content on unexpected request results doesn't work for the last block #5649

Closed
imsodin opened this issue Apr 12, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@imsodin
Copy link
Member

commented Apr 12, 2019

Detected in https://forum.syncthing.net/t/pull-no-such-file-error/13139/22

This is a super corner case:

  1. Program allocates space and thus sets modtime.
  2. Syncthing scans.
  3. Program does the actual change on disk, that only affects the last block of the file.
  4. Peer requests that last block.

Result: Block index too high error.
Expected: File gets force rescanned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.