Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on Windows 10 with filesystem watching #5695

Closed
FomalhautWeisszwerg opened this issue May 8, 2019 · 5 comments

Comments

Projects
None yet
3 participants
@FomalhautWeisszwerg
Copy link

commented May 8, 2019

Problem

Syncthing v1.1.2 that runs on Windows 10 cause panic during synchronizing files with the other node.

Environment

Node 0

OS: Debian GNU/Linux
Syncthing version: v1.1.2

Node 1

OS: Windows 10 Pro (version 10.0.18362 N/A Build 18362)
Syncthing version: v1.1.2

Steps to reproduce the problem

  1. Run Syncthing on the Node0 (Debian) with command syncthing 2>&1

  2. Run Syncthing on the Node1 (Windows10) with command syncthing

  3. Syncthing on the Node1 always causes panic.

Log

The file panic-20190508-223555.log was recorded on the Node1 (Windows10).

Do you have any ideas?

@calmh

This comment has been minimized.

Copy link
Member

commented May 8, 2019

panic: bug: Notify backend is processing a change outside of the filesystem root:
  f.root==\\?\D:\, root==\\?\d:\ (lower), path==d:\fossil_repository (lower)

Workaround: turn off filesystem watching, for the time being...

Smoking gun: #5633, although not clear to me if this breaks everywhere (why did it pass testing?) or if there's some corner case here.

@calmh calmh added the bug label May 8, 2019

@calmh calmh changed the title [Windows] syncthing v1.1.2 cause panic on Windows 10 (x64) Panic on Windows 10 with filesystem watching May 8, 2019

@calmh calmh added this to the v1.1.3 milestone May 8, 2019

@calmh calmh closed this in a04fcfe May 8, 2019

calmh added a commit that referenced this issue May 8, 2019

Merge branch 'release'
* release:
  lib/fs: Revert removal of \\?\ for drive letters (fixes #5695)
@calmh

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Hello from the future!

Screenshot 2019-05-08 at 17 39 47

@calmh

This comment has been minimized.

Copy link
Member

commented May 8, 2019

I’ve dropped a v1.1.3 release to fix the panic. Filesystem watching of whole disks still won’t work properly though (#5578, same as in v1.1.1).

@calmh

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Wow the time warp on the comments here...

@uok

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

a glitch in the Github matrix... If you see a Windows 10 agent... RUN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.