Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bundle doesn't include errors list, instead printing `Support bundle: failed to create errors.json: <nil>` #5766

Closed
calmh opened this issue Jun 9, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@calmh
Copy link
Member

commented Jun 9, 2019

The logic is wrong in the error handling.

@calmh calmh added the bug label Jun 9, 2019

@calmh calmh closed this in 41ff4b3 Jun 9, 2019

calmh added a commit to calmh/syncthing that referenced this issue Jun 10, 2019

Merge branch 'master' into crashrep
* master:
  lib/connections: Do not leak FDs, fix address copy (fixes syncthing#5767) (syncthing#5768)
  lib/api: Correct logic for errors.jons in support bundle (fixes syncthing#5766)
  all: Remove "large blocks" config (syncthing#5763)
  lib/build: Version 1.2 will be the Fermium Flea
  readme: Remove old, dead link (fixes syncthing#5760)
  gui: Don't call API when no modal is open (fixes syncthing#5652) (syncthing#5759)
  lib/protocol: Prioritize close msg and add close timeout (syncthing#5746)
  gui, man, authors: Update docs, translations, and contributors
  build(deps): bump github.com/lucas-clemente/quic-go (syncthing#5761)
  lib/protocol: Return from ClusterConfig when closed (syncthing#5752)
  build(deps): bump golang.org/x/text from 0.3.0 to 0.3.2 (syncthing#5751)

@calmh calmh added this to the v1.2.0 milestone Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.