Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI theme not changing on WebKit-based/like browsers #5810

Closed
EeveeEuphoria opened this issue Jun 20, 2019 · 2 comments
Closed

GUI theme not changing on WebKit-based/like browsers #5810

EeveeEuphoria opened this issue Jun 20, 2019 · 2 comments
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Milestone
v1.3.2

Comments

@EeveeEuphoria
Copy link

Hi there! I'm having an issue when it comes to changing the GUI theme on Vivaldi/Midori, that is not replicable in Firefox. When I attempt to change the GUI theme on either of my Syncthing instances, it does not actually change, even when the page is refreshed, browser closed down entirely, or Syncthing is restarted.

However in Firefox, the change immediately takes affect and is shown. I am not sure what causes this, however I have isolated it to be a WebKit bug due to it happening on Midori and Vivaldi, of which Midori uses WebKit, and Vivaldi is based on a modified version of Chromium.

Notably, when the theme is changed on Vivaldi, Firefox reports the theme as being the incorrect one. And changing the theme on Firefox corrects it for Firefox, but not Vivaldi.

Version Information
Syncthing Version: v1.1.4, Linux (64 bit) & v1.1.4, Linux (ARM)
OS Version: Arch Linux (Anarchy Linux, 64-bit) / Arch Linux ARM (Raspberry Pi 3 Model B)
Browser Version: Vivaldi 2.6.1566.40 (Stable channel) (64-bit)/Midori Web Browser 8.0/Firefox 67.0.3 (64-bit)

Provided below are two screenshots; the first one shows Vivaldi connected to the Raspberry Pi 3 Syncthing instance, and it showing the wrong theme. The next one shows Vivaldi connecting to the local instance of Syncthing, and it also showing the wrong theme.

Screenshot from 2019-06-20 14-37-52
Screenshot from 2019-06-20 14-39-01
@iwittkau
Copy link

I can replicate the behavior on Safari Version 12.1.1 on macOS. However, when I empty the cache and reload the page, the GUI theme changes take effect.

@CyberFoxHax
Copy link

I confirm this too. @iwittkau Thanks for the workaround.

AudriusButkevicius added a commit to AudriusButkevicius/syncthing that referenced this issue Nov 8, 2019
@AudriusButkevicius
lib/api: Reset mtime after theme change (fixes syncthing#5810)
996790d
@calmh calmh closed this as completed in 65c172c Nov 8, 2019
@calmh calmh added this to the v1.3.2 milestone Nov 8, 2019
@calmh calmh added the bug A problem with current functionality, as opposed to missing functionality (enhancement) label Nov 11, 2019
calmh added a commit to calmh/syncthing that referenced this issue Nov 11, 2019
@calmh
Merge branch 'master' into dbastr3
4a09a1b 
* master:
  docker: Add stdiscosrv and strelaysrv Dockerfiles (syncthing#6143)
  lib/protocol: Buffer allocation when compressing (fixes syncthing#6146) (syncthing#6147)
  golang-ci: Upgrade, skipping the white space complainer
  all: Cleanups enabled by Go 1.12
  lib/tlsutil: Remove Go 1.12 TLS 1.3 beta opt-in
  lib/api: Make theme paths relative (syncthing#6142)
  gui, lib/api: Adds support for prefers-color-scheme (fixes syncthing#6115)
  lib/api: Reset mtime after theme change (fixes syncthing#5810) (syncthing#6140)
  lib/model: Remove some testing deadlocks (syncthing#6138)
  lib/model: Add test for previous commit
  lib/model: Add initial deviceStatRefs on model creation (fixes syncthing#6136) (syncthing#6137)
  lib/model: Add folders on start in model (syncthing#6135)
  cmd/stbench: rm -r cmd/stbench (syncthing#6131)
  lib/api: Slightly unflake TestCSRFRequired by allowing longer timeout
  Fix bufferpool puts (ref syncthing#4976) (syncthing#6125)
  all: Remove dead code, fix lost msgLen checks (syncthing#6129)
  lib/upnp: Fix outdated comment (syncthing#6110)
calmh added a commit to calmh/syncthing that referenced this issue Nov 11, 2019
@calmh
Merge branch 'dbastr3' into badger
5c0b87e 
* dbastr3: (37 commits)
  docker: Add stdiscosrv and strelaysrv Dockerfiles (syncthing#6143)
  lib/protocol: Buffer allocation when compressing (fixes syncthing#6146) (syncthing#6147)
  golang-ci: Upgrade, skipping the white space complainer
  all: Cleanups enabled by Go 1.12
  lib/tlsutil: Remove Go 1.12 TLS 1.3 beta opt-in
  lib/api: Make theme paths relative (syncthing#6142)
  gui, lib/api: Adds support for prefers-color-scheme (fixes syncthing#6115)
  lib/api: Reset mtime after theme change (fixes syncthing#5810) (syncthing#6140)
  lib/model: Remove some testing deadlocks (syncthing#6138)
  lib/model: Add test for previous commit
  lib/model: Add initial deviceStatRefs on model creation (fixes syncthing#6136) (syncthing#6137)
  lib/model: Add folders on start in model (syncthing#6135)
  wip
  wip
  wip
  wip
  cmd/stbench: rm -r cmd/stbench (syncthing#6131)
  lib/api: Slightly unflake TestCSRFRequired by allowing longer timeout
  Fix bufferpool puts (ref syncthing#4976) (syncthing#6125)
  wip
  ...
calmh added a commit to calmh/syncthing that referenced this issue Nov 17, 2019
@calmh
Merge branch 'master' into logsuppression
f206d40 
* master:
  golang-ci: Skip "cognitive complexity" check for now
  lib/model: Prevent cleanup-race in testing (ref syncthing#6152) (syncthing#6155)
  gui: Decrease padding on the panel and modal bodies (syncthing#6153)
  lib/model: In tests prevent goroutine leaks and increase timeouts (syncthing#6152)
  lib/model: Simplify pull error/retry logic (fixes syncthing#6139) (syncthing#6141)
  docker: Add stdiscosrv and strelaysrv Dockerfiles (syncthing#6143)
  lib/protocol: Buffer allocation when compressing (fixes syncthing#6146) (syncthing#6147)
  golang-ci: Upgrade, skipping the white space complainer
  all: Cleanups enabled by Go 1.12
  lib/tlsutil: Remove Go 1.12 TLS 1.3 beta opt-in
  lib/api: Make theme paths relative (syncthing#6142)
  gui, lib/api: Adds support for prefers-color-scheme (fixes syncthing#6115)
  lib/api: Reset mtime after theme change (fixes syncthing#5810) (syncthing#6140)
  lib/model: Remove some testing deadlocks (syncthing#6138)
  lib/model: Add test for previous commit
  lib/model: Add initial deviceStatRefs on model creation (fixes syncthing#6136) (syncthing#6137)
  lib/model: Add folders on start in model (syncthing#6135)
calmh added a commit to calmh/syncthing that referenced this issue Nov 24, 2019
@calmh
Merge branch 'logsuppression' of https://github.com/calmh/syncthing i…
4adcd30 
…nto logsuppression

* 'logsuppression' of https://github.com/calmh/syncthing:
  wip
  golang-ci: Skip "cognitive complexity" check for now
  lib/model: Prevent cleanup-race in testing (ref syncthing#6152) (syncthing#6155)
  gui: Decrease padding on the panel and modal bodies (syncthing#6153)
  lib/model: In tests prevent goroutine leaks and increase timeouts (syncthing#6152)
  lib/model: Simplify pull error/retry logic (fixes syncthing#6139) (syncthing#6141)
  docker: Add stdiscosrv and strelaysrv Dockerfiles (syncthing#6143)
  lib/protocol: Buffer allocation when compressing (fixes syncthing#6146) (syncthing#6147)
  golang-ci: Upgrade, skipping the white space complainer
  all: Cleanups enabled by Go 1.12
  lib/tlsutil: Remove Go 1.12 TLS 1.3 beta opt-in
  lib/api: Make theme paths relative (syncthing#6142)
  gui, lib/api: Adds support for prefers-color-scheme (fixes syncthing#6115)
  lib/api: Reset mtime after theme change (fixes syncthing#5810) (syncthing#6140)
  lib/model: Remove some testing deadlocks (syncthing#6138)
  lib/model: Add test for previous commit
  lib/model: Add initial deviceStatRefs on model creation (fixes syncthing#6136) (syncthing#6137)
  lib/model: Add folders on start in model (syncthing#6135)
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Nov 8, 2020
@syncthing syncthing locked and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.3.2
Development

No branches or pull requests
5 participants
@calmh @iwittkau @CyberFoxHax @EeveeEuphoria @st-review