Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some sync errors get cleared despite them still being valid #6139

Closed
imsodin opened this issue Nov 8, 2019 · 0 comments

Comments

@imsodin
Copy link
Member

@imsodin imsodin commented Nov 8, 2019

When there were no changes recorded in a pull iteration, we reset all errors. However for some errors which are not recoverable through other sync actions (invalid filenames, file not available, maybe more) we do not increment the changes counter, to prevent another iteration. The errors however are still valid and should not be reset.

This was discovered in https://forum.syncthing.net/t/14-out-of-sync-items/14048

imsodin added a commit to imsodin/syncthing that referenced this issue Nov 8, 2019
@calmh calmh closed this in ce72bee Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.