Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted encrypted files don't show up as locally changed in web UI #7715

Closed
imsodin opened this issue May 28, 2021 · 0 comments
Closed

Deleted encrypted files don't show up as locally changed in web UI #7715

imsodin opened this issue May 28, 2021 · 0 comments
Assignees
@imsodin
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Milestone
v1.18.5

Comments

@imsodin
Copy link
Member

imsodin commented May 28, 2021

If you delete an encrypted file in a receive-only folder, i.e. do that manually in the filesystem, that won't register in the UI. It will look like everything is ok.

Reason is that we have an ugly hack to satisfy two requirements:

  • Locally changed items from a receive-encrypted folder must never be sent to remotes.
  • Locally added items that are deleted again aren't a problem, thus shouldn't show as local changes in the web UI.

The ugly hack is to ignore all items that have the locally-changed flag set and are deleted. That's fine for actually spurious files, that were removed, but obviously not for files that should be there.

PR incoming.
@imsodin imsodin added the bug A problem with current functionality, as opposed to missing functionality (enhancement) label May 28, 2021
@imsodin imsodin self-assigned this May 28, 2021
imsodin added a commit to imsodin/syncthing that referenced this issue May 28, 2021
@imsodin
gui, lib: Fix tracking deleted locally-changed on encrypted (fixes sy…
3e27a8b 
…ncthing#7715)
imsodin added a commit to imsodin/syncthing that referenced this issue May 28, 2021
@imsodin
gui, lib: Fix tracking deleted locally-changed on encrypted (fixes sy…
4e4e78e 
…ncthing#7715)
imsodin added a commit to imsodin/syncthing that referenced this issue May 28, 2021
@imsodin
gui, lib: Fix tracking deleted locally-changed on encrypted (fixes sy…
63db8b6 
…ncthing#7715)
imsodin added a commit to imsodin/syncthing that referenced this issue May 28, 2021
@imsodin
gui, lib: Fix tracking deleted locally-changed on encrypted (fixes sy…
b0cc427 
…ncthing#7715)
imsodin added a commit to imsodin/syncthing that referenced this issue May 31, 2021
@imsodin
gui, lib: Fix tracking deleted locally-changed on encrypted (fixes sy…
968c9e0 
…ncthing#7715)
@imsodin imsodin mentioned this issue May 31, 2021
Merged
@calmh calmh closed this as completed in 591e4d8 Nov 10, 2021
@calmh calmh added this to the v1.18.5 milestone Nov 10, 2021
calmh added a commit to calmh/syncthing that referenced this issue Nov 22, 2021
@calmh
Merge branch 'main' into ioutil
d1a36c2 
* main: (32 commits)
  cmd/syncthing: Implement generate as a subcommand with optional API credential setting (fixes syncthing#8021) (syncthing#8043)
  lib/model: Correct "reverting folder" log entry
  lib/model: Correct handling of fakefs cache
  gui, lib: Fix tracking deleted locally-changed on encrypted (fixes syncthing#7715) (syncthing#7726)
  lib/config: Move the bcrypt password hashing to GUIConfiguration (syncthing#8028)
  lib/syncthing: Clean up / refactor LoadOrGenerateCertificate() utility function. (syncthing#8025)
  lib/api: http.Request.BasicAuth instead of custom code (syncthing#8039)
  Normalize CLI options to always use two dashes. (syncthing#8037)
  gui: Display identicons for discovered device IDs. (syncthing#8022)
  cmd/syncthing/cli: indexDumpSize doesn't need a heap (syncthing#8024)
  lib/model: Optimize jobQueue performance and memory use (syncthing#8023)
  lib/model: Limit the number of default hashers on Android (ref syncthing#2220)
  lib/model: Set mod. time after writing trailer in shortcut (ref syncthing#7992)
  lib/protocol: Simplify codeToError, errorToCode
  lib/protocol: Eliminate nativeModel on Unix
  gui: Add direct link to Ignore Patterns from folder panel (fixes syncthing#4293) (syncthing#7993)
  gui: Translate theme names in settings (syncthing#8006)
  lib/model: Pull when a new connection is established (fixes syncthing#8012) (syncthing#8013)
  gui, man, authors: Update docs, translations, and contributors
  gui, man, authors: Update docs, translations, and contributors
  ...
calmh added a commit to calmh/syncthing that referenced this issue Nov 22, 2021
@calmh
Merge branch 'main' into conn-test
a9c9fb1 
* main: (32 commits)
  cmd/syncthing: Implement generate as a subcommand with optional API credential setting (fixes syncthing#8021) (syncthing#8043)
  lib/model: Correct "reverting folder" log entry
  lib/model: Correct handling of fakefs cache
  gui, lib: Fix tracking deleted locally-changed on encrypted (fixes syncthing#7715) (syncthing#7726)
  lib/config: Move the bcrypt password hashing to GUIConfiguration (syncthing#8028)
  lib/syncthing: Clean up / refactor LoadOrGenerateCertificate() utility function. (syncthing#8025)
  lib/api: http.Request.BasicAuth instead of custom code (syncthing#8039)
  Normalize CLI options to always use two dashes. (syncthing#8037)
  gui: Display identicons for discovered device IDs. (syncthing#8022)
  cmd/syncthing/cli: indexDumpSize doesn't need a heap (syncthing#8024)
  lib/model: Optimize jobQueue performance and memory use (syncthing#8023)
  lib/model: Limit the number of default hashers on Android (ref syncthing#2220)
  lib/model: Set mod. time after writing trailer in shortcut (ref syncthing#7992)
  lib/protocol: Simplify codeToError, errorToCode
  lib/protocol: Eliminate nativeModel on Unix
  gui: Add direct link to Ignore Patterns from folder panel (fixes syncthing#4293) (syncthing#7993)
  gui: Translate theme names in settings (syncthing#8006)
  lib/model: Pull when a new connection is established (fixes syncthing#8012) (syncthing#8013)
  gui, man, authors: Update docs, translations, and contributors
  gui, man, authors: Update docs, translations, and contributors
  ...
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Mar 10, 2023
@syncthing syncthing locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@imsodin imsodin

Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.18.5
Development

No branches or pull requests
3 participants
@calmh @imsodin @st-review