Enable log rotation by automatically closing log file (fixes #2251) #2420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is too nasty... This enables renaming the log file for rotation, and within at most a minute we'll reopen a new file at the specified name.
We don't do any magic locking, so theoretically this should work on Windows too, although doing log rotation there is left as an exercise for the reader... Just doing nothing results in same behavior as we have right now.