New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GUI #2425

Closed
wants to merge 15 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@gillisig
Contributor

gillisig commented Nov 2, 2015

In order to try to force myself to finish the new GUI, I'm making this pull request now. It is still very much WIP. This GUI has been discussed here and here

Here is a non-exhaustive list of TODOs

  • Move notifications into notification dropdown
  • Make mobile version of table - something like this: http://codepen.io/geoffreyrose/pen/azdJNO
  • Add identicon which shows status color (green: In sync, yellow: syncing red: out of sync) to device column and add syncing percentage to tooltip.
  • Link plus button in action column to a little device modal to add and remove devices to this folder (example: https://invis.io/PN4RLWGXH)
  • Make edit folder/device screens be more like this: https://invis.io/3M4RLYRJP
  • Add advanced button to edit folder/device screens hides/shows advances sections and fields.
  • Make local device data in header fold into a "drawer" on mobile that expands when clicked on local device name

I'll add more items to the list as I remember them.

I appreciate any help available. I am not that familiar with AngularJS so I would especially appreciate help with the parts relating to Angular, like moving notifications to the dropdown and more.

It currently looks like this on the surface:
screen shot 2015-11-02 at 09 39 53

@gillisig gillisig changed the title from GUI to New GUI Nov 2, 2015

@AudriusButkevicius

This comment has been minimized.

Member

AudriusButkevicius commented Nov 2, 2015

❤️

@calmh

This comment has been minimized.

Member

calmh commented Nov 2, 2015

Ooh, neat!

@calmh calmh added this to the v0.13 "Copper Cockroach" milestone Nov 2, 2015

@calmh calmh force-pushed the syncthing:master branch from a18ed7e to 945ddc2 Nov 21, 2015

@calmh calmh modified the milestones: v0.13 "Copper Cockroach", v.next Nov 22, 2015

@calmh calmh modified the milestones: Planned, Unplanned (Contributions Welcome) Jan 1, 2016

@calmh calmh removed this from the Planned milestone Jan 1, 2016

@lkwg82

This comment has been minimized.

Member

lkwg82 commented Mar 16, 2016

Do you need help?

@gillisig

This comment has been minimized.

Contributor

gillisig commented Mar 17, 2016

@lkwg82 yes absolutely, feel free to checkout my repo and make pull-request. It would especially if you have angular experience since I'm not that experienced with it.

@lkwg82

This comment has been minimized.

Member

lkwg82 commented Mar 17, 2016

@calmh what dou you think about the GUI build system. It is grunt again. Some time ago I proposed it for the Website. What is your current opinion in this?

@AudriusButkevicius

This comment has been minimized.

Member

AudriusButkevicius commented Mar 17, 2016

You can just use STGUIASSETS and edit files directly, why do you need grunt? There is nothing to compile.

@calmh

This comment has been minimized.

Member

calmh commented Mar 17, 2016

Indeed I'm unconvinced of the need of a build system here. Yes, loading the GUI would be more efficient with minification and concatenation and stuff, but in 99% of cases this is from localhost and is a matter of milliseconds anyway.

@lkwg82

This comment has been minimized.

Member

lkwg82 commented Mar 17, 2016

IMHO: Minification and concatination justifies in an almost always local setup with a single-page app not the additional complexity.

So there is only left using sass. I like sass too, no question. But is there any reasonable tooling for sass without grunt? Is the css that complex to cut complexity with sass substantially? (I guess no.)

These questions are needed to be answered to prepare the planning of additional steps.

  • cleanup (maybe to use no grunt and sass)
  • solving merge conflicts
  • identify missing UI elements
@lkwg82

This comment has been minimized.

Member

lkwg82 commented May 11, 2016

I'd like to close this PR as stalled.

@lkwg82 lkwg82 added the pr-WIP label May 11, 2016

@calmh

This comment has been minimized.

Member

calmh commented May 12, 2016

For now

@calmh calmh closed this May 12, 2016

@syncthing syncthing locked and limited conversation to collaborators Jun 16, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.