Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Update protobuf package 1.0.0 -> 1.2.0 #5452

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
2 participants
@calmh
Copy link
Member

commented Jan 14, 2019

Also adds a few file global options to keep the generated code similar to what we already had.

Purpose

Newness. I had a memory that there was some complication in this upgrade that I wanted to sort out, but it does not appear such now.

Testing

Not much beyond the units, but the generated code doesn't appear to differ significantly apart from a bunch of new XXX_... methods that are apparently mandatory. We should be good.

all: Update protobuf package 1.0.0 -> 1.2.0
Also adds a few file global options to keep the generated code similar
to what we already had.

@calmh calmh merged commit b01edca into syncthing:master Jan 14, 2019

6 checks passed

Build (Linux, Cross) (Syncthing) TeamCity build finished
Details
Build (Mac) (Syncthing) TeamCity build finished
Details
Build (Source) (Syncthing) TeamCity build finished
Details
Build (Windows) (Syncthing) TeamCity build finished
Details
Check Correctness (Syncthing) TeamCity build finished
Details
Check Old Go Version (Syncthing) TeamCity build finished
Details

@calmh calmh deleted the calmh:proto branch Jan 14, 2019

@AudriusButkevicius

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

Xxx could he disabled before.

@calmh

This comment has been minimized.

Copy link
Member Author

commented Jan 14, 2019

There are some xxx fields that can be disabled (the options I added), the methods are new from upstream (golang/protobuf) and apparently not disableable.

@calmh calmh modified the milestones: v1.0.2, v1.0.1 Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.