Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
GUI: Split device list in folder sharing options by shared / unshared #5756
This is part of (and a prerequisite for) the idea outlined in this forum discussion to list suggested devices that could improve cluster connectivity. So far, this PR only separates the "already shared with" (declared as category 1 in the discussion) devices from the unshared (category 3) devices in two sections, each of which is hidden when empty. As a side-effect, that makes it easier to see what changes have been made in the checkmarks before saving.
Folder editing has been verified for a cluster of two remote devices, every combination of shared or unshared. Adding a new folder looks as expected, with only the second section visible. Adding a pending folder (sent from a peer) does so as well, with the inviting device checked.
TODO! Should check for screenshots and texts in Usage guide.
According to the usage stats the average user has 3 devices. In the sharing settings a device can either be shared (= checked box) or not shared (= unchecked box) so I in my opinion splitting the 2-3 entries into two sections is not helpful, even confusing for usability.
referenced this pull request
May 30, 2019
In fact, these categories look quite crowded if each has only one or two entries. We could maybe collapse them if the number of entries is small. On the other hand, the "average" cluster with only three devices will probably have only one section because everything is shared with everyone.