Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Split device list in folder sharing options by shared / unshared #5756

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@acolomb
Copy link
Contributor

commented May 30, 2019

Purpose

This is part of (and a prerequisite for) the idea outlined in this forum discussion to list suggested devices that could improve cluster connectivity. So far, this PR only separates the "already shared with" (declared as category 1 in the discussion) devices from the unshared (category 3) devices in two sections, each of which is hidden when empty. As a side-effect, that makes it easier to see what changes have been made in the checkmarks before saving.

Testing

Folder editing has been verified for a cluster of two remote devices, every combination of shared or unshared. Adding a new folder looks as expected, with only the second section visible. Adding a pending folder (sent from a peer) does so as well, with the inviting device checked.

Screenshots

Screenshot_2019-05-30 devtest Syncthing

Documentation

TODO! Should check for screenshots and texts in Usage guide.

acolomb added some commits May 30, 2019

gui: Reduce code duplication among {de}selectAllDevices().
Instead of repeating the complete looping code, use an optional
boolean argument in selectAllDevices().  deSelectAllDevices() just
flips it to false and reuses the other function.
gui: Split device list in folder sharing options panel.
Split the device list into two sections, for currently shared and
unshared devices.  Makes it clearer what changes are being made, just
by looking at the checkmarks.  Initially the first section has all
checked and the second section has all unchecked.  An empty section is
hidden.

Implement device list filters for the separated categories,
temporarily stored within the GUI model's currentFolder object while
the folder editing modal dialog is active.  Adjust bulk selection
functions.
@uok

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

According to the usage stats the average user has 3 devices. In the sharing settings a device can either be shared (= checked box) or not shared (= unchecked box) so I in my opinion splitting the 2-3 entries into two sections is not helpful, even confusing for usability.

@acolomb

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

@uok Thanks for your consideration. As mentioned above, this is just a stop-gap for having an additional category of "suggested" devices (see #5758).

In fact, these categories look quite crowded if each has only one or two entries. We could maybe collapse them if the number of entries is small. On the other hand, the "average" cluster with only three devices will probably have only one section because everything is shared with everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.