Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NATSymmetricUDPFirewall to punchable NATs #5931

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@olifre
Copy link
Contributor

commented Aug 6, 2019

NATSymmetricUDPFirewall actually is not NAT at all, but means the machine has a global IP address and an UDP firewall in front (RFC calls it Symmetric UDP Firewall). This is punchable fine, both theoretically and also practically in testing.

Purpose

See https://forum.syncthing.net/t/issues-with-quic-transport/13590/6 , this allows to use QUIC also for hosts which are behind an UDP firewall with a global IP address.

Testing

I tested with a host behind a NATSymmetricUDPFirewall and after the change, punching worked fine.

Documentation

If this is a user visible change (including API and protocol changes), add a link here
to the corresponding pull request on https://github.com/syncthing/docs or describe
the documentation changes necessary.

Authorship

Your name and email will be added automatically to the AUTHORS file
based on the commit metadata.

Add NATSymmetricUDPFirewall to punchable NATs
NATSymmetricUDPFirewall actually is not NAT at all, but means the machine has a global IP address and an UDP firewall in front (RFC calls it Symmetric UDP Firewall). This is punchable fine, both theoretically and also practically in testing.

@AudriusButkevicius AudriusButkevicius merged commit edf2399 into syncthing:master Aug 6, 2019

8 checks passed

Build (Linux, Cross) (Syncthing) TeamCity build finished
Details
Build (Mac) (Syncthing) TeamCity build finished
Details
Build (Source) (Syncthing) TeamCity build finished
Details
Build (Windows) (Syncthing) TeamCity build finished
Details
Check Correctness (Syncthing) TeamCity build finished
Details
Check Old Go Version (Syncthing) TeamCity build finished
Details
Coverage (Syncthing) TeamCity build finished
Details
GolangCI No issues found!
Details

@olifre olifre deleted the olifre:patch-1 branch Aug 6, 2019

@calmh calmh added this to the v1.2.2 milestone Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.