Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update golangci for go v1.13 #6042

Merged
merged 1 commit into from Oct 13, 2019

Conversation

@chenrui333
Copy link
Contributor

commented Oct 1, 2019

Purpose

Per golang 1.13.1 upgrade, did some cleanup as well as upgrade golangci (v1.18.0 starting supporting go v1.13)

Testing

n/a

Screenshots

N/A

Documentation

No user facing changes.

Relates to Homebrew/homebrew-core#44765

@calmh

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

Thanks, CI update is fine, the rest is unnecessary at this point. We don't plan to make use of 1.13 language features until 1.15 is out, so the go.mod change is not due.

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

ok, I will limit my change to golangci update then. Thanks for the quick feedback!

@chenrui333 chenrui333 force-pushed the chenrui333:go-1.13.1 branch from b84dcdd to d9dbad8 Oct 1, 2019
@chenrui333 chenrui333 changed the title Go 1.13.1 Update golangci for go v1.13 Oct 1, 2019
@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

@calmh Updated.

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2019

@calmh ping :)

@imsodin imsodin changed the title Update golangci for go v1.13 build: Update golangci for go v1.13 Oct 13, 2019
@imsodin imsodin merged commit 9d6b663 into syncthing:master Oct 13, 2019
8 checks passed
8 checks passed
Build (Linux, Cross) (Syncthing) TeamCity build finished
Details
Build (Mac) (Syncthing) TeamCity build finished
Details
Build (Source) (Syncthing) TeamCity build finished
Details
Build (Windows) (Syncthing) TeamCity build finished
Details
Check Correctness (Syncthing) TeamCity build finished
Details
Check Old Go Version (Syncthing) TeamCity build finished
Details
Coverage (Syncthing) TeamCity build finished
Details
GolangCI No issues found!
Details
@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented Oct 13, 2019

Thanks @imsodin!!

@calmh calmh added this to the v1.3.2 milestone Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.