Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement basic push notification logic #6244
Implement native browser push notifications on some important events. Closes #5329.
For now notifications are handled client-side, the tab must be always open (but not necessarily visible) to receive notifications.
As discussed here some events need to be notified to user.
Note: Notifications are shown by the browser and the operating system. Depending of these the style could be different of mine. If you already saw notifications from a website, it will be shown like these.
First, you need to enable notifications in settings panel as show in the screenshot above.
A notification is shown when :
I've drafted this PR to have feedback on implementations and priorities before going too deeper in it.
AudriusButkevicius left a comment
Looks like a good thing to build on, yet I suspect we'll have users screaming that they don't want this, or screaming that they want more (up to the levels of silly notification per file). Perhaps this could be configurable.
I've asked a few questions to see how we're taking this forward.