lib/ur: use sysctl syscall to get RAM size on Mac #6468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Mar 30, 2020
* master: (63 commits) go.mod: Update jackpal/gateway dependency (fixes syncthing#5288) (syncthing#6469) lib/protocol: faster Luhn algorithm and better testing (syncthing#6475) lib/protocol: Remove unused channel Connection.preventSends (syncthing#6473) lib/weakhash: Fix speed reporting in benchmark (syncthing#6470) build: Simplify/correct Windows version tagging (fixes syncthing#6471) (syncthing#6472) lib/ur: Use sysctl syscall to get RAM size on Mac (syncthing#6468) lib/model: Do Revert/Override synchronously (syncthing#6460) lib/syncthing: Save version to db after upgrade ops are done (ref syncthing#6457) (syncthing#6458) cmd/ursrv: Minor heatmap tweaks lib/model: Remove unused func (syncthing#6456) cmd/ursrv: Use OpenStreetMap and Leaflet for heat map (ref syncthing#6150) (syncthing#6454) cmd/ursrv: Provide cached locations.json authors: Fixup keevBush gui, man, authors: Update docs, translations, and contributors go.mod: Update quic-go to 0.14.4 (syncthing#6453) all: Pass db intervals as args not env vars (syncthing#6448) lib/api: Set ServerName on LDAPS connections (fixes syncthing#6450) (syncthing#6451) lib/model: Unset local flag on deleted files (fixes syncthing#6436) (syncthing#6449) gui: Improve unused device status (fixes syncthing#6416) (syncthing#6445) gui, lib/model: Fix for folder stats with r-o and ignoreDel (fixes syncthing#6430) (syncthing#6431) ...
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
syncthing currently spawns a process to get the memory size on Darwin. It can instead do a single system call to get this information.
The other BSDs could probably do this too, except that the "memsize" parameter name appears to be MacOS-specific.
Testing
Trigger a usage report in the UI: Settings, Anonymous Usage Reporting, Preview.