Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/scanner: Do not drop all not-exist-errors and debug logging #7675

Merged
merged 2 commits into from May 15, 2021
Merged

lib/scanner: Do not drop all not-exist-errors and debug logging #7675

merged 2 commits into from May 15, 2021

Conversation

imsodin
Copy link
Member

@imsodin imsodin commented May 14, 2021

@imsodin imsodin changed the title lib/scanner: Extend and improve debug logging lib/scanner: Do not drop not-exist-errors and debug logging May 14, 2021
@imsodin imsodin changed the title lib/scanner: Do not drop not-exist-errors and debug logging lib/scanner: Do not drop all not-exist-errors and debug logging May 14, 2021
@imsodin imsodin marked this pull request as ready for review May 14, 2021 19:45
@imsodin
Copy link
Member Author

imsodin commented May 14, 2021

This fixes an actual usability bug: We drop all fs.IsNotExist errors. We do that because we might be asked to scan something that doesn't exist, which isn't actually an error (#5385). However having the check there at the end means it also drops legitimate errors, like in this case normalization errors. Thus I moved the fs.IsNotExist check to the error check in walkAndHashFiles.

@imsodin imsodin merged commit 93a02c6 into syncthing:main May 15, 2021
@imsodin imsodin deleted the scanner/debug branch May 15, 2021 09:51
@st-release st-release added this to the v1.17.0 milestone May 25, 2021
@calmh calmh added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Aug 11, 2022
@syncthing syncthing locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@calmh calmh calmh approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imsodin @calmh @st-release