Integration Editor: Save as Draft should display notification on success

[dsimansk]

This is a...

[x] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Documentation issue or request

The problem

Derived from #1828 && #1947.

When button Save as Draft currently there's no indication for user to know if everything is saved successfully or not.

Expected behavior

Toas notification is displayed on successful save or error otherwise.

Screenshot

See preview gif in #1947

[gashcrumb]

Ideally our save function should consistently work so that the user trusts that clicking save actually saves :-)

Also I dislike gratuitous notifications. I think notifications should be the exception, not the rule, and we do a big inline notification if there's a save error.

[gashcrumb]

Ideally our save function should consistently work so that the user trusts that clicking save actually saves :-)

Also I dislike gratuitous notifications. I think notifications should be the exception, not the rule, and we do a big inline notification if there's a save error.

[dsimansk]

Hmm a green button maybe :) It feels like that current Save as Draft is lacking a visual representation of success. But it might be just me.

@sjcox-rh @dongniwang could you pls review a Save as Draft behaviour if you find a bit of spare time?

[dsimansk]

Hmm a green button maybe :) It feels like that current Save as Draft is lacking a visual representation of success. But it might be just me.

@sjcox-rh @dongniwang could you pls review a Save as Draft behaviour if you find a bit of spare time?

[sjcox-rh]

@dsimansk, @gashcrumb

Agree with stan that I wouldn't necessarily want to show a toast notification here but it would be nice to show a subtle success state for saving a draft.

How about changing the "Save as Draft" button to show status, like below.

I visually changed it so it is no longer a button (no outline, gradient, shadow) but simply informs the user that the save was successful. Would retain state until a change was made to the integration, then would return to "Save as draft" button.

@dongniwang, fyi, let me know if you agree with this direction.

[sjcox-rh]

@dsimansk, @gashcrumb

Agree with stan that I wouldn't necessarily want to show a toast notification here but it would be nice to show a subtle success state for saving a draft.

How about changing the "Save as Draft" button to show status, like below.

I visually changed it so it is no longer a button (no outline, gradient, shadow) but simply informs the user that the save was successful. Would retain state until a change was made to the integration, then would return to "Save as draft" button.

@dongniwang, fyi, let me know if you agree with this direction.

[dongniwang]

I like the the approach of displaying the dynamic status within the area of the button. It feels more responsive and lightweight. @sjcox-rh

Just a couple questions for implementation:

• How long does it take to save an integration? I noticed there's a spinner icon in place currently once user clicks the "Save as Draft" button.
• I know SJ mentioned that it would remain its state unless a change was made. And I wondered if we want it to just remain its state (the green checkmark) for a couple seconds then return back to "Save as Draft".
• If a dynamic button is too much, maybe we could go with the old way of just displaying a line of text alongside with the buttons. Something like "Last saved today at 2:20 pm"?

[dongniwang]

I like the the approach of displaying the dynamic status within the area of the button. It feels more responsive and lightweight. @sjcox-rh

Just a couple questions for implementation:

• How long does it take to save an integration? I noticed there's a spinner icon in place currently once user clicks the "Save as Draft" button.
• I know SJ mentioned that it would remain its state unless a change was made. And I wondered if we want it to just remain its state (the green checkmark) for a couple seconds then return back to "Save as Draft".
• If a dynamic button is too much, maybe we could go with the old way of just displaying a line of text alongside with the buttons. Something like "Last saved today at 2:20 pm"?

[amysueg]

Solving this will need to also include scenarios where save as draft does not work as expected.

[amysueg]

Solving this will need to also include scenarios where save as draft does not work as expected.

[stale]

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

[stale]

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

[amysueg]

@sjcox-rh I wonder if this could be folded in with work on Autosave?
@dongniwang, fyi

[amysueg]

@sjcox-rh I wonder if this could be folded in with work on Autosave?
@dongniwang, fyi

[gashcrumb]

Autosave makes this issue obsolete really

[gashcrumb]

Autosave makes this issue obsolete really

[amysueg]

Should we assume autosave #3048 will happen and thus close this issue @gashcrumb @gaughan?
fyi @dongniwang @sjcox-rh

[amysueg]

Should we assume autosave #3048 will happen and thus close this issue @gashcrumb @gaughan?
fyi @dongniwang @sjcox-rh

[gashcrumb]

I think so, honestly I don't see this particular issue ever being worked; we're going in a different direction so makes sense to close it.

[gashcrumb]

I think so, honestly I don't see this particular issue ever being worked; we're going in a different direction so makes sense to close it.

[amysueg]

Per @gashcrumb closing.

[amysueg]

Per @gashcrumb closing.