/syndesis

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create LOGOUT Endpoint #2561

Closed
paoloantinori opened this Issue May 7, 2018 · 2 comments

Comments

Assignees

@zregvart zregvart

Labels
Projects
  
In progress in Sprint 30 (Test Board)
  
In progress in Sprint 31 - Tasks
Milestone
  Sprint 31 (3/5)
3 participants
@paoloantinori @zregvart @mcada
@paoloantinori
Contributor

paoloantinori commented May 7, 2018

This is a...


[x] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Documentation issue or request

The problem

Implement a "Logout" server-side endpoint, to take care of performing complex logic.
Different environments have a different specific configuration, and a server side endpoint is probably the ideal place to centralize the responsibility of taking care all the differences.

This is the continuation of this older enhancement: #2511

@paoloantinori paoloantinori added cat/feature group/server prio/p0 labels May 7, 2018

@paoloantinori paoloantinori added this to the Post GA (7.1) milestone May 7, 2018

@paoloantinori paoloantinori assigned zregvart May 7, 2018

@pure-bot pure-bot bot added the notif/triage label May 7, 2018

@paoloantinori

This comment has been minimized.

Show comment
Hide comment
@paoloantinori

paoloantinori May 7, 2018

Contributor

//notify @gashcrumb @dsimansk
Contributor

paoloantinori commented May 7, 2018

//notify @gashcrumb @dsimansk

@paoloantinori paoloantinori referenced this issue May 7, 2018

Closed

redirect to externalized URL when logging out #2511

@paoloantinori

This comment has been minimized.

Show comment
Hide comment
@paoloantinori

paoloantinori May 7, 2018

Contributor

In case it might turn useful, we have a curl scripted oauth dance, working on minishift, here:

https://github.com/syndesisio/syndesis/blob/master/tools/bin/commands/dev
Contributor

paoloantinori commented May 7, 2018

In case it might turn useful, we have a curl scripted oauth dance, working on minishift, here:

https://github.com/syndesisio/syndesis/blob/master/tools/bin/commands/dev

@paoloantinori paoloantinori removed the notif/triage label May 10, 2018

@zregvart zregvart modified the milestones: Post GA (7.1), Sprint 30 (2/5) Jun 4, 2018

@heiko-braun heiko-braun added this to In progress in Sprint 30 (Test Board) Jun 23, 2018

@paoloantinori paoloantinori modified the milestones: Sprint 30 (2/5), Sprint 31 (3/5) Jun 25, 2018

@mcada mcada added the qe/logout-test label Jun 28, 2018

@heiko-braun heiko-braun added this to To do in Sprint 31 - Tasks Jul 5, 2018

@heiko-braun heiko-braun moved this from To do to In progress in Sprint 31 - Tasks Jul 5, 2018

zregvart added a commit to zregvart/syndesis that referenced this issue Jul 6, 2018

@zregvart
chore(ui): logout endpoint 
This adds a `/logout` endpoint backed by nginx and static logout.html
file.

When `/logout` endpoint is requested with the 'SYNDESIS_XSRF_TOKEN` set
to `awesome` the response will expire the `_oauth_proxy` cookie. In any
case it will serve the `logout.html`.

The UI when performing the logout will replace the `window.document`
with the response of the `/logout` endpoint and will set the URL to
`/logout`.

This design protects the denial of service if the `/logout` endpoint is
invoked cross origin and allows for the served page to be reloaded
making it deterministic and thus safer.

The `logout.html` embeds the used CSS and just displays a simple _You
have been logged out_ message offering to Login again by linking to `/`.

Fixes syndesisio#2561
Verified
This commit was signed with a verified signature.
@zregvart zregvart Zoran Regvart
GPG key ID: 6D9197EFE5AB7D75 Learn about signing commits
4819da3

@zregvart zregvart referenced this issue Jul 6, 2018

Merged

chore(ui): logout endpoint #2995

zregvart added a commit to zregvart/syndesis that referenced this issue Jul 9, 2018

@zregvart
chore(ui): logout endpoint 
This adds a `/logout` endpoint backed by nginx and static logout.html
file.

When `/logout` endpoint is requested with the 'SYNDESIS_XSRF_TOKEN` set
to `awesome` the response will expire the `_oauth_proxy` cookie. In any
case it will serve the `logout.html`.

The UI when performing the logout will replace the `window.document`
with the response of the `/logout` endpoint and will set the URL to
`/logout`.

This design protects the denial of service if the `/logout` endpoint is
invoked cross origin and allows for the served page to be reloaded
making it deterministic and thus safer.

The `logout.html` embeds the used CSS and just displays a simple _You
have been logged out_ message offering to Login again by linking to `/`.

Fixes syndesisio#2561
Verified
This commit was signed with a verified signature.
@zregvart zregvart Zoran Regvart
GPG key ID: 6D9197EFE5AB7D75 Learn about signing commits
e400116

@pure-bot pure-bot bot closed this in #2995 Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment