New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import integration, when I press "cancel" integration get's imported #2587

Closed
tplevko opened this Issue May 10, 2018 · 4 comments

Comments

Projects
6 participants
@tplevko
Contributor

tplevko commented May 10, 2018

This is a...


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ x ] Bug report  
[ ] Documentation issue or request

The problem

There is a "Cancel" button, for integration import. When I press it, the integration get's imported.

Expected behavior

I think it would be nice, if the integration was not imported when I press the "Cancel" button. For the confirmation of import, there is the "Done" button.

Screenshot

out

Tasks involved / Steps to Reproduce

  1. Press "import integration"
  2. Select integration to import
  3. Press "Cancel" button
@gashcrumb

This comment has been minimized.

Show comment
Hide comment
@gashcrumb

gashcrumb May 10, 2018

Contributor

@kahboom can you look into this one when you get a chance?

Contributor

gashcrumb commented May 10, 2018

@kahboom can you look into this one when you get a chance?

@heiko-braun heiko-braun added this to Backlog in Bug Backlog Jun 23, 2018

@paoloantinori paoloantinori added group/ui and removed notif/triage labels Jul 4, 2018

@heiko-braun heiko-braun added this to the Sprint 32 (4/5) milestone Jul 9, 2018

@heiko-braun heiko-braun added this to In Progress in QE issues Jul 16, 2018

@heiko-braun heiko-braun moved this from In Progress to Backlog in QE issues Jul 16, 2018

@phantomjinx phantomjinx self-assigned this Jul 17, 2018

@gashcrumb

This comment has been minimized.

Show comment
Hide comment
@gashcrumb

gashcrumb Jul 17, 2018

Contributor

@phantomjinx I'll take this one, actually working on the page now...

Contributor

gashcrumb commented Jul 17, 2018

@phantomjinx I'll take this one, actually working on the page now...

@kahboom

This comment has been minimized.

Show comment
Hide comment
@kahboom

kahboom Jul 17, 2018

Contributor

Woah, no idea how I didn't realize I had been tagged in this--my apologies @gashcrumb . Next time ping me on IRC if I don't respond right away on here.

Contributor

kahboom commented Jul 17, 2018

Woah, no idea how I didn't realize I had been tagged in this--my apologies @gashcrumb . Next time ping me on IRC if I don't respond right away on here.

@gashcrumb

This comment has been minimized.

Show comment
Hide comment
@gashcrumb

gashcrumb Jul 17, 2018

Contributor

The integration is imported immediately on selection/file drop, so 'cancel' is meaningless in this context, I'm going to probably get rid of the cancel button in favor of Done for #3101.

Contributor

gashcrumb commented Jul 17, 2018

The integration is imported immediately on selection/file drop, so 'cancel' is meaningless in this context, I'm going to probably get rid of the cancel button in favor of Done for #3101.

@gashcrumb gashcrumb closed this Jul 17, 2018

@project-bot project-bot bot moved this from Backlog to Closed in Bug Backlog Jul 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment