Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upImport integration, when I press "cancel" integration get's imported #2587
Comments
tplevko
added
cat/bug
prio/p1
group/integration
labels
May 10, 2018
pure-bot
bot
added
the
notif/triage
label
May 10, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@kahboom can you look into this one when you get a chance? |
heiko-braun
added this to Backlog
in Bug Backlog
Jun 23, 2018
paoloantinori
added
group/ui
and removed
notif/triage
labels
Jul 4, 2018
heiko-braun
added this to the Sprint 32 (4/5) milestone
Jul 9, 2018
heiko-braun
added this to In Progress
in QE issues
Jul 16, 2018
heiko-braun
moved this from In Progress
to Backlog
in QE issues
Jul 16, 2018
heiko-braun
added
the
source/qe
label
Jul 16, 2018
phantomjinx
self-assigned this
Jul 17, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
gashcrumb
Jul 17, 2018
Contributor
@phantomjinx I'll take this one, actually working on the page now...
|
@phantomjinx I'll take this one, actually working on the page now... |
gashcrumb
unassigned
phantomjinx
Jul 17, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
kahboom
Jul 17, 2018
Contributor
Woah, no idea how I didn't realize I had been tagged in this--my apologies @gashcrumb . Next time ping me on IRC if I don't respond right away on here.
|
Woah, no idea how I didn't realize I had been tagged in this--my apologies @gashcrumb . Next time ping me on IRC if I don't respond right away on here. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
gashcrumb
Jul 17, 2018
Contributor
The integration is imported immediately on selection/file drop, so 'cancel' is meaningless in this context, I'm going to probably get rid of the cancel button in favor of Done for #3101.
|
The integration is imported immediately on selection/file drop, so 'cancel' is meaningless in this context, I'm going to probably get rid of the cancel button in favor of Done for #3101. |
tplevko commentedMay 10, 2018
This is a...
The problem
There is a "Cancel" button, for integration import. When I press it, the integration get's imported.
Expected behavior
I think it would be nice, if the integration was not imported when I press the "Cancel" button. For the confirmation of import, there is the "Done" button.
Screenshot
Tasks involved / Steps to Reproduce