New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a correct sorting in 'Sets' [$25 awarded] #372

Closed
Svarov-RZM opened this Issue May 29, 2017 · 11 comments

Comments

4 participants
@Svarov-RZM
Copy link

Svarov-RZM commented May 29, 2017

Description:

Synfig has a very nice thing called 'Sets'. You can add diffident control layers in it and easily access them from one place. I use it extremely. But layers inside a set are sorted randomly without any pattern: nor alphabetically nor by Z depth, which increase the time to find the needed layer. This is how it looks:
setssorting

See? Random order, but should be: R-1, R-2, R-3, etc.

Feature request:

Implement a correct sorting algorithm in 'Sets' panel. It can sort by name or by Z depth. For me, alphabetical sorting would be ideal, but if it possible to implement different methods it would be great.

To reproduce:

Open attached file (done in 1.3.3) and go to 'Window->Sets', you'll see that layers are sorted in a random order.
Note: Synfig can actually sort it right sometimes, so if it looks OK, restart the program several times until you see a screwed up sorting.
BadSorting.zip

Experienced on:

All versions since 1.0.2 on Windows 10. Didn't test on other platforms.


The $25 bounty on this issue has been claimed at Bountysource.

@zozorg

This comment has been minimized.

Copy link

zozorg commented Dec 12, 2017

Added $10 ( total $25 ), it would be even better to be able to move it around ( kind of a "set Z-depth" ), but alphabetical order should be OK too.

@caryoscelus

This comment has been minimized.

Copy link
Collaborator

caryoscelus commented Dec 12, 2017

As far as i can tell, it sorts by "last added to set". You can see this by creating two sets and dragging layer around them: it will always come on bottom.

Anyway, if you're ok with sets themselves being sorted, name sorting should be pretty easy to implement. In fact, i already got sorting half-working (newly-added layers are not sorted, until you click).

@caryoscelus

This comment has been minimized.

Copy link
Collaborator

caryoscelus commented Dec 12, 2017

So yeah, name sorting works fine now.
sets_sorted

caryoscelus added a commit to caryoscelus/synfig that referenced this issue Dec 12, 2017

@caryoscelus caryoscelus added the Fixed label Dec 12, 2017

@caryoscelus caryoscelus self-assigned this Dec 13, 2017

@morevnaproject morevnaproject added this to Done in Releases Dec 13, 2017

@caryoscelus caryoscelus removed their assignment Dec 14, 2017

@caryoscelus

This comment has been minimized.

Copy link
Collaborator

caryoscelus commented Dec 14, 2017

Added z depth as well.

caryoscelus added a commit to caryoscelus/synfig that referenced this issue Dec 14, 2017

@caryoscelus

This comment has been minimized.

Copy link
Collaborator

caryoscelus commented Dec 17, 2017

Svarov rejected: Hey, I would like to test it first before accepting the claim. Can you provide an installer with 'Sets' fixed? Or we can always wait for the official dev build.

I can build .deb for debian testing or unstable, i guess. Or you can wait for morevna project build. I don't care either way.

@morevnaproject

This comment has been minimized.

Copy link
Member

morevnaproject commented Dec 17, 2017

I have configured our buildbot to make a test build for this feature. Should be ready by tomorrow. ^__^

@morevnaproject

This comment has been minimized.

Copy link
Member

morevnaproject commented Dec 17, 2017

/remind me about the thing in 12 hours

@reminders reminders bot added the reminder label Dec 17, 2017

@reminders

This comment has been minimized.

Copy link

reminders bot commented Dec 17, 2017

@morevnaproject set a reminder for Tomorrow at 5:21 AM

@reminders reminders bot reopened this Dec 18, 2017

@reminders reminders bot removed the reminder label Dec 18, 2017

@reminders

This comment has been minimized.

Copy link

reminders bot commented Dec 18, 2017

👋 @morevnaproject, about the thing

@Svarov-RZM

This comment has been minimized.

Copy link

Svarov-RZM commented Dec 19, 2017

Tested it. Works perfectly - thanks!

@caryoscelus
You can submit the claim again.
Seems that bountysource does not allow you to change your mind after you initially rejected the claim :(

@morevnaproject morevnaproject moved this from Done to Released in Releases Feb 22, 2018

@morevnaproject morevnaproject changed the title Implement a correct sorting in 'Sets' Implement a correct sorting in 'Sets' [$25 awarded] Mar 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment