Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window position not remembered and default is in an odd place #523

Closed
keithnbrown opened this Issue Apr 17, 2018 · 10 comments

Comments

5 participants
@keithnbrown
Copy link

keithnbrown commented Apr 17, 2018

Synfig version & platform:
version 1.3.6 Windows 10 64-bit

Issue description:

The window never remembers last position, or maximised-ness. The initial postion also seems to be ever-so-slightly offset from the corner.

It may be notable that i have 2 monitors.

This screenshot shows my desktop and synfig's initial postition. my monitor divide is the red line
synfig

It may be worth noting that the handles for resizing the windows (that is the area where the cursor changes) are also very far away from the edges of the window, so this would suggest a skinning issue

@keithnbrown keithnbrown changed the title Window position not rememberd and default is in an odd place Window position not remembered and default is in an odd place Apr 17, 2018

@FadhilKwan

This comment has been minimized.

Copy link

FadhilKwan commented Apr 18, 2018

Does this also have anything to do with skin issue? #487
It happened to my Synfig, and i'm also using dual stretched display mode

And look what i've found when the synfig got frozen
snip_20180418194714

why that box is bigger than the actual window...?

does it have anything to do with the drop shadow of the window...?
snip_20180418195401

@ice0 ice0 added the GUI label Apr 21, 2018

@ice0

This comment has been minimized.

Copy link
Collaborator

ice0 commented Apr 21, 2018

The initial postion also seems to be ever-so-slightly offset from the corner.

I will check this. Possible this is theme related problem.

It may be worth noting that the handles for resizing the windows (that is the area where the cursor changes) are also very far away from the edges of the window, so this would suggest a skinning issue.

Can you make a screenshot showing how far away cursor is?

does it have anything to do with the drop shadow of the window...?

Yeah, i also think so.

@FadhilKwan

This comment has been minimized.

Copy link

FadhilKwan commented Apr 21, 2018

Can you make a screenshot showing how far away cursor is?

All sides or only these three sides would do...?

here's the maximum distance for the cursor to change
snip_20180421115124
snip_20180421115103
snip_20180421115022

But oddly enough, the minimum distance for these cursors is actually its window (and slight off a tiny amount of pixels...?)
snip_20180421115725
snip_20180421115701
snip_20180421115630

sorry if it doesn't look that great, i can't snapshot the cursor so i have to use the OBS preview window instead
Also, i put it in front of white BG (it was notepad window) to compare it with the drop shadow

@BobSynfig

This comment has been minimized.

Copy link
Collaborator

BobSynfig commented Dec 16, 2018

This is due to a bug of implementation of shadows in GTK3 for Windows
See 2. of Suboptimal window drawing on Windows

@morevnaproject

This comment has been minimized.

Copy link
Member

morevnaproject commented Jan 2, 2019

Okay, so we can solve this by applying this patch when doing our own build of GTK for windows - https://github.com/Alexpux/MINGW-packages/blob/master/mingw-w64-gtk3/0001-gtkwindow-Don-t-force-enable-CSD-under-Windows.patch

This can be done as part of #666.

@morevnaproject

This comment has been minimized.

Copy link
Member

morevnaproject commented Jan 2, 2019

This can be done as part of #666.

...also, this is already patched if we use MSYS2 for building - https://gitlab.gnome.org/GNOME/gtk/issues/105#note_82344
The support for MSYS2 can be added as part of #694.

@BobSynfig

This comment has been minimized.

Copy link
Collaborator

BobSynfig commented Jan 5, 2019

For now it can be solved by editing synfigstudio.bat (in Synfig's folder)
add set GTK_CSD=0
before

cd "%~dp0\"
start "" "%~dp0\bin\synfigstudio.exe"

then start SynfigStudio from synfigstudio.bat (you can modify your desktop shortcut)
@morevnaproject it could be included in the distributed packages ;)

@morevnaproject

This comment has been minimized.

Copy link
Member

morevnaproject commented Jan 8, 2019

can be solved by editing synfigstudio.bat (in Synfig's folder)

@BobSynfig Awesome! This is such a simple solution! I will do the fix. ^__^

@morevnaproject morevnaproject self-assigned this Jan 8, 2019

morevnaproject added a commit to morevnaproject/morevna-builds that referenced this issue Jan 14, 2019

@morevnaproject morevnaproject added this to In Progress in Releases Jan 17, 2019

@morevnaproject

This comment has been minimized.

Copy link
Member

morevnaproject commented Jan 19, 2019

@morevnaproject

This comment has been minimized.

Copy link
Member

morevnaproject commented Jan 26, 2019

Here is a fixed build with icons and CSD patch - https://downloads.synfig.org/almost-1.3.11/SynfigStudio-1.3.11-pre5-64bit-2365f.zip

screenshot_007

@morevnaproject morevnaproject moved this from In Progress to Done in Releases Feb 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.