Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox initial dropdown state #650

Closed
wstaelens opened this Issue Oct 18, 2018 · 10 comments

Comments

5 participants
@wstaelens
Copy link
Contributor

wstaelens commented Oct 18, 2018

Synfig version & platform:
SF 1.2.2
Windows 10 x64 Pro

Issue description:

synfig white combo

first time i see a lot of white when opening. the items should be starting on top...

@ice0

This comment has been minimized.

Copy link
Collaborator

ice0 commented Nov 12, 2018

This is a known GTK+ combobox problem (discussed here https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/388633), so i am not sure it can be fixed at this time.

@wstaelens

This comment has been minimized.

Copy link
Contributor Author

wstaelens commented Nov 12, 2018

Time to move to .NET Standard/.NET Core ? ;-) ;-)
Hope to see it soon fixed, as this is really a basic control.... Not expecting to still see such bugs in GTK+...

@Jose-Moreno

This comment has been minimized.

Copy link

Jose-Moreno commented Nov 12, 2018

@wstaelens If you read the bug discussion that @ice0 linked the developers say it's "intended design" so they will never "fix" it. 😕

Edit: I searched a bit more as I couldn't believe that it was such a design feature to ignore it, and it seems theyve been locking their older repository and moving the bugs to gitlab, so the bug is still considered a bug and it's at least healthy important so it might be resolved in the future, thank goodness https://gitlab.gnome.org/GNOME/gtk/issues/270

Edit 2: Still it says a lot that the bug has been around for almost 12 years without anyone fixing it.... 😩

@ice0

This comment has been minimized.

Copy link
Collaborator

ice0 commented Nov 13, 2018

As a workaround, we can move the default value to the bottom of the list. @morevnaproject, what do you think?

@wstaelens

This comment has been minimized.

Copy link
Contributor Author

wstaelens commented Nov 13, 2018

I think it would be better to bomb that gitlab bug ticket so that it gets some attention and hopefully a fix.

@morevnaproject

This comment has been minimized.

Copy link
Member

morevnaproject commented Dec 24, 2018

Interesting information from http://libregraphicsworld.org/blog/entry/week-recap-23-december-2018 -

Kevin Stoffler contributed a patch that works around the design decision of GTK+ developers regarding drop-down lists. Instead of always showing the currently selected item of a drop-down list under the cursor (at the cost of showing a lot of blank space above), GIMP now renders the whole list in a much nicer way (while losing the item selection). The patch was applied to both unit selection and blend mode selection. Smaller UX changes involve things like keeping aspect by default when scaling with the Unified Transform tool.

@morevnaproject

This comment has been minimized.

@morevnaproject

This comment has been minimized.

@BobSynfig

This comment has been minimized.

Copy link
Collaborator

BobSynfig commented Dec 26, 2018

Test done ok

Add this line in /synfig-studio/src/gui/widgets/widget_enum.cpp (line 65)

this->set_wrap_width(1); //#650

As a result, depending the size and the position of the window, the default value may not be selected by default.
650
We could also change the value to have a tabular display (I used 4 here).
The drawback: it affects any Widget_Enum (for now)
650-2

@morevnaproject

This comment has been minimized.

Copy link
Member

morevnaproject commented Jan 2, 2019

The change is applied now. Thanks to everyone for participation!

@morevnaproject morevnaproject added this to Done in Releases Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.