Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in "convert to time loop", link time cannot be set to zero #659

Open
zozorg opened this Issue Oct 23, 2018 · 3 comments

Comments

3 participants
@zozorg
Copy link

zozorg commented Oct 23, 2018

Synfig version & platform:
1.3.10

Issue description:
Convert anything to "time loop", set "link time" to anything other than 0, then try to set it back to zero ; nothing happens, the old value is kept.
I'm pretty sure I have seen something like this happen with other values.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@BobSynfig

This comment has been minimized.

Copy link
Collaborator

BobSynfig commented Dec 28, 2018

Related to #520 and #526

According my tests,
when 2 or more parameters
of the same type
follow in the list
if you try to edit a parameter
with the same value
as the one placed under,
it can't be changed.

For example:

  • Time Loop has Link Time, Local Time and Duration as Time
  • Circle has Z Depth and Amount as Real
  • Star has
    Z Depth and Amount as Real
    Type of Feather and Winding Style as Integer (Combo Enum)
    Outer Radius and Inner Radius as Real

It bugs in any case, red error messages appear in console.
Surely a missing reinitialisation in cellrenderer_value.cpp or widget_value.cpp in case of no change of type

Also note that Synfig often crashes after such error!

@BobSynfig

This comment has been minimized.

Copy link
Collaborator

BobSynfig commented Dec 29, 2018

So, when the edition of parameter has been done, the new value is compared with the former one.
For some reason, it uses property_value() which doesn't give the original one, which was used in the beginning to define the content of the edit box!
I did a copy of these original data in a synfig::ValueBase saved_data which I will use for the final compare ;)

Note that modify Z Order will still lead to crash like in 1.2.2
For the rest, everything can be modified as expected now :)
#691

@morevnaproject

This comment has been minimized.

Copy link
Member

morevnaproject commented Dec 30, 2018

Much thanks to @BobSynfig - seems like it is fixed now! Will be shipped with version 1.3.11. Still we ask for your testing.

@morevnaproject morevnaproject added this to Done in Releases Dec 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.