Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new workarea rendering mode: Preview #729

Closed
morevnaproject opened this Issue Feb 14, 2019 · 10 comments

Comments

Projects
None yet
3 participants
@morevnaproject
Copy link
Member

morevnaproject commented Feb 14, 2019

This continues issue #409.

Long story short:

In 17812bc we have added downsampling for images. This greatly improves quality if your scene uses big images scaled to smaller size. Unfortunately, this operation demands additional CPU resources and you will notice general application slowdown when working with such scenes.

You can enable Draft rendering mode (it disables downasampling), but this solution doesn't fits for all cases, as it is hides many layers, which could be important for you.

So, we need one more rendering mode, which displays all possible layers, but with some simplifications - i.e. no downsampling (maybe some other simplifications can be added).

I suggest to call this new rendering mode "Preview".

So, we will have 3 rendering modes:

  • "Draft" (simplifications + some layers hidden).
  • "Preview" (some simplifications, not influencing image look very much).
  • And the last one, which renders without any simplifications - I suggest to call it "Final".
@morevnaproject

This comment has been minimized.

Copy link
Member Author

morevnaproject commented Mar 1, 2019

For solving this issue read about Synfig's render engines here - https://synfig-docs-dev.readthedocs.io/en/latest/common/structure.html#render-engine

@Gilraiser

This comment has been minimized.

Copy link

Gilraiser commented Mar 1, 2019

Good Morning,

Hi, I suggest that you create a rendering mode in which only the contours are visible. Not only the contour layer, but also the other types of layers, such as gradients, etc. It would be very useful and I think it could be very light.

Thanks, I hope it helps.

See you soon.

@morevnaproject

This comment has been minimized.

Copy link
Member Author

morevnaproject commented Mar 1, 2019

@Gilraiser Yes, I understand - this is called "Outline" or "Wireframe" view in other apps. Can you please open a separate issue for that? ^__^

@ankit-kumar-dwivedi

This comment has been minimized.

Copy link
Contributor

ankit-kumar-dwivedi commented Mar 1, 2019

@morevnaproject I would love to work on this one.

For solving this issue read about Synfig's render engines here - https://synfig-docs-dev.readthedocs.io/en/latest/common/structure.html#render-engine
working on it 👍

@ankit-kumar-dwivedi

This comment has been minimized.

Copy link
Contributor

ankit-kumar-dwivedi commented Mar 2, 2019

@morevnaproject can you tell me what do you mean by

which displays all possible layers, but with some simplifications - i.e. no downsampling (maybe some other simplifications can be added).

As mentioned in #409 (comment) some layers were disabled and rest were simplified. So do want each and every layer to be simplified in preview mode?

@morevnaproject

This comment has been minimized.

Copy link
Member Author

morevnaproject commented Mar 2, 2019

In Preview mode we would like all layers to be displayed. So, it's more close to "Final" view mode, than "Draft" view mode.

Here's what I expect at first stage:

  1. Create a copy of "Final" Renderer (it is a part of "Software" Sub-Engine), rename it to "Preview".
  2. Take a look at "Draft" Renderer and see which Optimizers we can include into "Preview" Renderer. So far we need only one Optimizer, which modifies how images are displayed: it disables supersampling and forces NearestNeighbour interpolation scaling method.

This is generally enough to have #710 solved effectively.

@morevnaproject

This comment has been minimized.

Copy link
Member Author

morevnaproject commented Mar 2, 2019

After you get done with changes above, the "Preview" Renderer will be available in Synfig Studio via Edit -> Preferences -> Render

screenshot_002

At the second stage we need to do necessary UI tweaks:

  1. Make "Preview" Renderer a default one for Synfig Studio.
  2. Allow to easy switch Renderer for user. Currently we have two main Renderers - "Final" and "Draft". By default "Final" Renderer is used and user can switch to "Draft" Renderer by clicking this button on toolbar:
    screenshot_001

After introducing "Preview" Renderer, we will have more than 2 Renderers, and switch button is not good anymore for changing Renderer. So, my suggestion is to replace switch button with dropdown list (combo-box).

@Gilraiser

This comment has been minimized.

Copy link

Gilraiser commented Mar 2, 2019

@Gilraiser Yes, I understand - this is called "Outline" or "Wireframe" view in other apps. Can you please open a separate issue for that? ^__^

Ok I will do it. Thank you.

ankit-kumar-dwivedi added a commit to ankit-kumar-dwivedi/synfig that referenced this issue Mar 6, 2019

Added Cobra-Preview renderering mode
Made the preview mode default
Fixes synfig#729
@ankit-kumar-dwivedi

This comment has been minimized.

Copy link
Contributor

ankit-kumar-dwivedi commented Mar 6, 2019

@morevnaproject I added the new rendering mode - "Cobra Preview" and made it the default renderer.
I verified it's working.

So far we need only one Optimizer, which modifies how images are displayed: it disables supersampling and forces NearestNeighbour interpolation scaling method.

The above line Implied to NEAREST INTERPOLATION so I used the OptimizerDraftTransformation
Will be sending a PR after making the GUI changes.

@ankit-kumar-dwivedi

This comment has been minimized.

Copy link
Contributor

ankit-kumar-dwivedi commented Mar 6, 2019

@morevnaproject Made a PR please review :)

morevnaproject added a commit to morevnaproject/synfig that referenced this issue Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.