Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Lock ratio button unexpectedly crops the canvas #771
Synfig version & platform:
Whereas if you don't click this button, and enter a new size (eg. smaller than the canvas), the project will be scaled down to render at the new size.
You can reset this incorrect behaviour by clicking the link button again so that the rings are now unlinked.
A french user had a similar problem of understanding about these options and it has be explained and solved here https://forums.synfig.org/t/agrandir-image-pas-juste-le-calque/9579
Thanks for getting back to me. I think we aren't talking about the same problem. I tried those options on the other tab, and it has no effect. The pages you linked too still don't explain this behaviour. And the French user isn't talking about this specific problem.
Why would the "lock ratio" link button suddenly switch the output to cropped? This button should only keep the width & height in ratio with each other or not. It shouldn't affect cropping vs scaling. For that there should be a separate explicit option that says "Crop to new size" or "Scale to new size".
I've created a video demonstrating the problem here, hope this helps;
Ok, I see what is your problem
You can render it, it works for both Canvas and Render ;)
Ah thank you. Well, even knowing this, I think it’s so against convention that to me it seems like a bug! I was just avoiding the button. And according to the forum thread, it seems everyone else who posted also thought it was a bug!…
On Fri, 15 Mar 2019 at 8:33 pm, BobSynfig ***@***.***> wrote: Ok, I see what is your problem Try the following - Original 1920x1080 - F8 (for modification of the canvas) or F9 (for render only) - In "Other", check "Image Aspect" and "Image Span"; other checkboxes are uncheked - In "Image", link "Image Size" and change "Width" to 1280, "Height" will be changed automatically to 720 - Validate You can render it, it works for both Canvas and Render ;) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#771 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHEXVZuI9TQANvQmM6SXClgnnLFuyBlHks5vW3cNgaJpZM4bzkO_> .
So, thanks to @ankit-kumar-dwivedi, "Image Aspect" and "Image Span" checkboxes are checked by default now.
And that made things work correctly when you have image width and height linked.
BUT, that introduces another issue: if you have width and height NOT linked, then changing one of them distorts the image.
We've got canvas stretched, not expanded.
Let me mention, that this could be good and expected behavior for case when we specify parameters for final rendering. I.e., we have composition 1920x1080 and render it to 1920x540 -> get stretched result -> OK.
But when we change composition properties for editing (via Canvas -> Properties), this is NOT "good and expected behavior".
Actually, what we come to is already has been mentioned in this post long time ago - http://www.segtsy.com/2013/12/a-significant-synfig-setback/ - image dimensions in "File - Render" serve different purpose than image dimensions in "Canvas - Properties".
Actually I think that article is talking about a different issue yet again, sadly...
Quotes from the above article, 5 years ago...
"In all other software programs the render size and project size are in two exclusively different parts of the program. Never have I seen the final render size affect the actual document/canvas size. It’s so weird."
In any case, this quote rings true for both issues;
"Setting up your file should be basic and easy to understand. It shouldn’t be hidden in cryptic units or wonky settings that change on a dime as you type them in. This is the front door of the software. If a user is turned off by the front door, we’ll most likely never get them to come inside and hang out."
The article contains screenshots from every other mainstream program showing how canvas size properties should be laid out.
sigh all I know is when using Synfig, just never touch that "lock ratio" button! I'm just going to continue working around it... it isn't any wonder when I asked about it on the forums, people said it was broken and not to touch it!
Yes normally we find minor inconveniences managable for free software, and it's to be expected. But actually I found Synfig to be pretty intuitive in most other ways! Well when I found I couldn't move things as I expected, a bit of googling showed me I had to group everything first. And that pictures import as 2 nested objects. But once I knew this it became evident there was a benefit to this, and I realised it was more flexible than flash, and am perfectly happy with these concepts!
This canvas thing isn' the hugest issue to be honest, because I can just avoid clicking the button. But this is a disproportionately weird one compared to Synfigs other idiosyncrasies, as it seems to throw people right off and think that something is a bug! And no immediate advantage that I can see...
Anyway if we have to give this a priority, I would say even though the chance of someone being confused by it is pretty much 100%, the chance of someone running into it as a problem is lower than that, and since I can work around it by never clicking that lock button, the impact is negligible in the end.
But if it causes lots of redundant messages / bug reports of people asking what the problem is, maybe then it's worth addressing :) Looks like I was one of the first to bring it up in a long time. The replies I got was that the button is "broken" so perhaps people are just quietly avoiding it and getting on with their work.
For now I'm just happy the issue has been raised. The only reason I'm so invested in discussing an issue like this is because I'm really liking Synfig ;)
Let's keep going with the issue. ^__^
Here is an interesting thing to mention.
I have a default document with default parameters:
My "locks and links" parameters are set as before the change made by #797:
Now, here is what I have if I change width and height manually, without the "chain" button disabled:
IMPORTANT: Notice the "Image span" value remains the same as in first screenshot.
But if I do the same operation with the "chain" button enabled, then I get the following:
IMPORTANT: Notice the "Image span" value changed!
So, I think the problem is with the "chain" button - for some reason it does something wrong.
Issue is fixed now via 6eafe8e.
Still I encourage to continue discussion raised by article - http://www.segtsy.com/2013/12/a-significant-synfig-setback/
Your suggestions for improvements of handling canvas size are welcome here - #777
The fix is shipped in version 1.3.12 - https://www.synfig.org/2020/02/07/synfig-studio-1-3-12-released/