"Current Version" doesn't update in WPF sample

[CoderNate]

I think the first thing a lot of people would do to try out this project is run the WPF sample app. When doing so it's likely they'll notice that the Current Version displayed on the main window usually doesn't change from 1.0 to 1.1 as expected after doing an "Install Now". In the following code from UpdateWindow.xaml.cs you can see it's possible for updateManager.CleanUp to finish before the BeginInvoke that closes the update window finishes. If that happens, the CleanUp method sets the updatemanager's state back to unchecked before the closed event handler inside the main window does its check to see that the state is AppliedSuccessfully. The Closed handler in the MainWindow code only calls OnPropertyChanged("AppVersion") if the state is AppliedSuccessfully. Maybe the easiest thing is to make sure the Update window closes before CleanUp is called.

private void InstallNow_Click(object sender, RoutedEventArgs e)
{
...
    Dispatcher d = Application.Current.Dispatcher;
    d.BeginInvoke(new Action(Hide));
    try
    {
        _updateManager.ApplyUpdates(true);
        d.BeginInvoke(new Action(Close));
    }
    catch
    {
        d.BeginInvoke(new Action(this.Show));
            // this.WindowState = WindowState.Normal;
        MessageBox.Show(
            "An error occurred while trying to install software updates");
    }

    _updateManager.CleanUp();
    d.BeginInvoke(new Action(this.Close));

    Action close = Close;

    if (Dispatcher.CheckAccess())
        close();
    else
        Dispatcher.Invoke(close);
...
}

[synhershko]

Can you please send a Pull Request with a fix which works for you?

[CoderNate]

I made a patch file. It only changes 5 lines in UpdateWindow.Xaml.cs. https://drive.google.com/file/d/0BzDPYJ5wsGqpQmtjUVpQT3dZWG8/view?usp=sharing
Hope that will work for you.

[robinwassen]

This has been fixed in commit: 6fc8c6f

Thanks for reporting this issue.