fix: publish android debug symbols#99
Conversation
|
Could we update this terminal publish path to run |
Updated the terminal publish recipe to run Validation:
Resolved in e373700 |
ben-kaufman
left a comment
There was a problem hiding this comment.
Looks good after reaudit.
Refs synonymdev/bitkit-android#982
Unblocks synonymdev/bitkit-android#988.
Description
Android release symbol extraction failed because previously published bitkit-core AARs contained stripped
libbitkitcore.sofiles without usable native debug metadata.This bumps bitkit-core to
0.1.70and changes the Android build/publish path so release artifacts keep native debug metadata and satisfy the Android 16 KB page-size alignment requirement:cargo ndk --no-strip.ANDROID_NDK_ROOTvia$GITHUB_ENVaftersetup-ndkso script and Gradle build/publish steps can find NDKllvm-readelf.build_android.shif any ABI lacks.symtab,.debug_*, or.gnu_debugdatametadata.readelf/llvm-readelfprogram-header output.llvm-readelffromANDROID_NDK_ROOT,ANDROID_NDK_HOME, orNDK_HOMEwhen it is not already onPATH.libbitkitcore.sosymbols through Gradle release AAR packaging.bundleReleaseAarand direct Gradle publish tasks fail if checked-injniLibslacks native debug metadata or 16 KB LOAD alignment../build_android.shbefore direct Gradle publish.Package.swiftchecksum for the same release version.Release
Preview
N/A
QA Notes
com.synonym:bitkit-core-android:0.1.70.bash -n build_android.sh.git diff --check../bindings/android/gradlew --project-dir ./bindings/android :lib:ktlintCheck../build_android.shrevalidated the terminal build/publish path and ran:lib:validateReleaseNativeLibrariesbeforepublishToMavenLocal../bindings/android/gradlew --project-dir ./bindings/android :lib:validateReleaseNativeLibrariesfails stale checked-injniLibsbefore regeneration, proving direct Gradle publish is guarded.llvm-readelfdiscovery throughANDROID_NDK_ROOT.llvm-readelf -W -lLOAD-alignment probe returned0x4000forarm64-v8a/libbitkitcore.so../build_android.sh../build_ios.sh.cargo fmt --check.cargo clippy(0 errors, existing warnings).cargo test --lib -- --skip modules::blocktank.3717f97d4c184509f8093a87f6d8a5c4085d771264d789d1102ab6321fbb3ed6.cargo testreached 358 passed before 11 existing Blocktank staging/regtest network tests timed out againstapi.stag.blocktank.to.