Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: In the 'backupSuccess' step of a TSQLDatabaseBackupEvent event handler, you couldn't delete the target database file #226

Merged
merged 5 commits into from Jul 30, 2019

Conversation

@edwinyzh
Copy link
Contributor

commented Jul 28, 2019

Note: I needed to delete the target db file after after I've compress the db file into a .zip file

edwinyzh added some commits Jul 28, 2019

Merge pull request #1 from synopse/master
merge original upstream synopse/mORMot to our forked repo
Fixed: In the 'backupSuccess' step of a TSQLDatabaseBackupEvent event…
… handler, you couldn't delete the target database file.

Note: I needed to delete the target db file after after I've compress the db file into a .zip file
@edwinyzh

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2019

Hi ab, would you merge this fix? Thanks.

@@ -3290,6 +3291,7 @@ TSQLDatabaseBackupThread = class(TThread)
property DestDB: TSQLDatabase read fDestDB;
/// the raised exception in case of backupFailure notification
property FailureError: Exception read fError;
property BackupDestFile: RawUTF8 read fBackupDestFile;

This comment has been minimized.

Copy link
@synopse

synopse Jul 29, 2019

Owner

please add a /// documentation comment

This comment has been minimized.

Copy link
@edwinyzh

edwinyzh Jul 30, 2019

Author Contributor

comment added

@@ -5776,12 +5779,17 @@ procedure TSQLDatabaseBackupThread.Execute;
raise ESQLite3Exception.Create('Backup process forced to terminate');
SleepHiRes(fStepSleepMS);
until false;

This comment has been minimized.

Copy link
@synopse

synopse Jul 29, 2019

Owner

please don't add void lines to the source ;)

edwinyzh added some commits Jul 30, 2019

Merge pull request #2 from synopse/master
merging upstream repository
added comment for the BackupDestFile property and removed blank lines…
… as requested by the original repository developer.

@synopse synopse merged commit 919a9ba into synopse:master Jul 30, 2019

synopse pushed a commit that referenced this pull request Jul 30, 2019

synopse pushed a commit that referenced this pull request Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.