Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug in TSChannelClient.Receive method. #227

Merged

Conversation

@transmogrifix
Copy link

commented Jul 28, 2019

Data in SECBUFFER_EXTRA was not handled properly, it was appended to the output data buffer before being decrypted.

I have noticed this bug while trying to use web sockets (useBidirSocket and WebSocketsEnable) with a server behind NGINX reverse proxy with SSL.

Svetozar Belic
Fixed a bug in TSChannelClient.Receive method. Data in SECBUFFER_EXTR…
…A was not handled properly, it was appended to the output data buffer before being decrypted.

@synopse synopse merged commit a7e1a5d into synopse:master Jul 29, 2019

@synopse

This comment has been minimized.

Copy link
Owner

commented Jul 29, 2019

I merged it, but something concerns me: your patch calls DecryptInput twice, even if InputCount is still 0 (no EXTRA bytes). @transmogrifix what do you think? I guess the following should be written:

  if InputCount = 0 then break;
  res := DecryptInput;
until false;

synopse pushed a commit that referenced this pull request Jul 29, 2019

Arnaud Bouchez
#227 adaptation
- thanks Svetozar for the patch!
@transmogrifix

This comment has been minimized.

Copy link
Author

commented Jul 29, 2019

You are right, I missed that.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.