Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pull for ARM. #249

Merged
merged 8 commits into from Oct 30, 2019

Conversation

@LongDirtyAnimAlf
Copy link
Contributor

LongDirtyAnimAlf commented Oct 27, 2019

All greens on ARM now.
Please review.

@synopse

This comment has been minimized.

Copy link

synopse commented on SynMongoDB.pas in 1a93705 Oct 28, 2019

this will break the MongoDB encoding for sure

This comment has been minimized.

Copy link
Owner Author

LongDirtyAnimAlf replied Oct 28, 2019

@synopse

This comment has been minimized.

Copy link

synopse commented on SQLite3/mORMot.pas in 1a93705 Oct 28, 2019

it compiles to the very same asm I suspect

Copy link
Owner

synopse left a comment

ok - I will merge it and do some quick review

  • not yet changing the default SVN revision support, until officially advertised

Thanks a lot!

@@ -20849,14 +20865,14 @@ procedure FastSetString(var s: RawUTF8; p: pointer; len: PtrInt);
begin
if len<=0 then
r := nil else begin
GetMem(r,len+(STRRECSIZE+4));
GetMem(r,len+(STRRECSIZE+2));

This comment has been minimized.

Copy link
@synopse

synopse Oct 30, 2019

Owner

it was on purpose that it added 4 Bytes, when used with aligned 32-bit reads....
but perhaps you are right and +2 is enough due to how memory alignement and heap manager work

This comment has been minimized.

Copy link
@LongDirtyAnimAlf

LongDirtyAnimAlf Oct 30, 2019

Author Contributor

I did not look into it very closely, but the +4 gave errors on ARM.
Did not look at assembler for a cause however.
I just accepted it as a compiler quirck ... ;-)

@synopse synopse merged commit dff34b9 into synopse:master Oct 30, 2019
synopse pushed a commit that referenced this pull request Oct 30, 2019
synopse pushed a commit that referenced this pull request Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.