New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo clean-up #58

Closed
bbroeksema opened this Issue Aug 19, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@bbroeksema
Collaborator

bbroeksema commented Aug 19, 2014

I'd like to propose some clean up of the code base:

  • The lib and data directories are both only required for the examples. As such I'd like to propose to move them into the examples directory and fix the examples accordingly.
  • There is no reason why d3 should be a git submodule. I think we could go with adding it the same way like all other dependencies for the examples: add d3.min.js to examples/lib (assuming lib moves down there).
  • The scratch directory seems to be an old left-over. I'd like to propose to remove it.

Any thoughts, comments? I can do the required work if you aggree.

@syntagmatic

This comment has been minimized.

Show comment
Hide comment
@syntagmatic

syntagmatic Aug 19, 2014

Owner

Moving lib/data to examples: sounds good.

D3 removed as a submodule: also sounds good. It's one less step getting started with the repo and D3's source/examples aren't necessary.

Removing scratch directory: remove it!

Thanks Bertjan.

Owner

syntagmatic commented Aug 19, 2014

Moving lib/data to examples: sounds good.

D3 removed as a submodule: also sounds good. It's one less step getting started with the repo and D3's source/examples aren't necessary.

Removing scratch directory: remove it!

Thanks Bertjan.

bbroeksema added a commit to bbroeksema/parallel-coordinates that referenced this issue Aug 19, 2014

Move data and lib into the examples directory.
Both dirs where there just for the examples to work, so let's keep them in
there and clean-up the top-level directory of the repo a bit.

#58

@bbroeksema bbroeksema closed this Aug 19, 2014

bbroeksema added a commit that referenced this issue Aug 19, 2014

Move data and lib into the examples directory.
Both dirs where there just for the examples to work, so let's keep them in
there and clean-up the top-level directory of the repo a bit.

#58
@syntagmatic

This comment has been minimized.

Show comment
Hide comment
@syntagmatic

syntagmatic Aug 19, 2014

Owner

Incremented the library to 0.4.0 for this reorganization

Owner

syntagmatic commented Aug 19, 2014

Incremented the library to 0.4.0 for this reorganization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment